Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: runtime/vm/service_event.cc

Issue 1756393002: Fix some service protocol isolate lifecycle races (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/service_event.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service_event.h" 5 #include "vm/service_event.h"
6 6
7 #include "vm/message_handler.h" 7 #include "vm/message_handler.h"
8 8
9 namespace dart { 9 namespace dart {
10 10
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 case kPauseStart: 108 case kPauseStart:
109 return "PauseStart"; 109 return "PauseStart";
110 case kPauseExit: 110 case kPauseExit:
111 return "PauseExit"; 111 return "PauseExit";
112 case kPauseBreakpoint: 112 case kPauseBreakpoint:
113 return "PauseBreakpoint"; 113 return "PauseBreakpoint";
114 case kPauseInterrupted: 114 case kPauseInterrupted:
115 return "PauseInterrupted"; 115 return "PauseInterrupted";
116 case kPauseException: 116 case kPauseException:
117 return "PauseException"; 117 return "PauseException";
118 case kNone:
119 return "None";
118 case kResume: 120 case kResume:
119 return "Resume"; 121 return "Resume";
120 case kBreakpointAdded: 122 case kBreakpointAdded:
121 return "BreakpointAdded"; 123 return "BreakpointAdded";
122 case kBreakpointResolved: 124 case kBreakpointResolved:
123 return "BreakpointResolved"; 125 return "BreakpointResolved";
124 case kBreakpointRemoved: 126 case kBreakpointRemoved:
125 return "BreakpointRemoved"; 127 return "BreakpointRemoved";
126 case kGC: 128 case kGC:
127 return "GC"; // TODO(koda): Change to GarbageCollected. 129 return "GC"; // TODO(koda): Change to GarbageCollected.
(...skipping 26 matching lines...) Expand all
154 case kIsolateExit: 156 case kIsolateExit:
155 case kIsolateUpdate: 157 case kIsolateUpdate:
156 case kServiceExtensionAdded: 158 case kServiceExtensionAdded:
157 return Service::isolate_stream.id(); 159 return Service::isolate_stream.id();
158 160
159 case kPauseStart: 161 case kPauseStart:
160 case kPauseExit: 162 case kPauseExit:
161 case kPauseBreakpoint: 163 case kPauseBreakpoint:
162 case kPauseInterrupted: 164 case kPauseInterrupted:
163 case kPauseException: 165 case kPauseException:
166 case kNone:
164 case kResume: 167 case kResume:
165 case kBreakpointAdded: 168 case kBreakpointAdded:
166 case kBreakpointResolved: 169 case kBreakpointResolved:
167 case kBreakpointRemoved: 170 case kBreakpointRemoved:
168 case kInspect: 171 case kInspect:
169 case kDebuggerSettingsUpdate: 172 case kDebuggerSettingsUpdate:
170 return Service::debug_stream.id(); 173 return Service::debug_stream.id();
171 174
172 case kGC: 175 case kGC:
173 return Service::gc_stream.id(); 176 return Service::gc_stream.id();
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 } else { 269 } else {
267 jsobj->AddProperty("isolate", isolate()); 270 jsobj->AddProperty("isolate", isolate());
268 } 271 }
269 ASSERT(timestamp_ != -1); 272 ASSERT(timestamp_ != -1);
270 jsobj->AddPropertyTimeMillis("timestamp", timestamp_); 273 jsobj->AddPropertyTimeMillis("timestamp", timestamp_);
271 } 274 }
272 275
273 #endif // !PRODUCT 276 #endif // !PRODUCT
274 277
275 } // namespace dart 278 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/service_event.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698