Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1756333002: Disable ignored / moot configs in DM. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
Brian Osman, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable ignored / moot configs in DM. - upright-matrix-* are ignored in Gold. Let's stop wasting time. - twice-8888 is silly. ViaTwice was added to help locally test caching / batching in the GPU backend. Running it into a software backend is not testing anything interesting, and doing that on the bots is doubly uninteresting. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756333002 Committed: https://skia.googlesource.com/skia/+/ed854fb897fa134f2f64738a75293502fdcf1af2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -60 lines) Patch
M tools/dm_flags.json View 7 chunks +0 lines, -52 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mtklein_C
4 years, 9 months ago (2016-03-02 21:58:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756333002/1
4 years, 9 months ago (2016-03-02 21:58:29 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 22:08:50 UTC) #7
Brian Osman
lgtm
4 years, 9 months ago (2016-03-02 22:31:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756333002/1
4 years, 9 months ago (2016-03-03 01:13:39 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 01:15:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ed854fb897fa134f2f64738a75293502fdcf1af2

Powered by Google App Engine
This is Rietveld 408576698