Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 17563009: Disable test with an expired certificate (Closed)

Created:
7 years, 6 months ago by rmsousa
Modified:
7 years, 6 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/cert/cert_verify_proc_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rmsousa
Committed patchset #1 manually as r207966.
7 years, 6 months ago (2013-06-22 00:21:02 UTC) #1
agl
7 years, 6 months ago (2013-06-22 01:14:21 UTC) #2
LGTM

On Fri, Jun 21, 2013 at 8:21 PM,  <rmsousa@chromium.org> wrote:
> Reviewers: agl,
>
> Message:
> Committed patchset #1 manually as r207966.
>
> Description:
> Disable test with an expired certificate
>
> TBR=agl@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207966
>
> Please review this at https://codereview.chromium.org/17563009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M net/cert/cert_verify_proc_unittest.cc
>
>
> Index: net/cert/cert_verify_proc_unittest.cc
> diff --git a/net/cert/cert_verify_proc_unittest.cc
> b/net/cert/cert_verify_proc_unittest.cc
> index
>
b8c6c5847a1e1e3b446030f564e58679ed9e56fe..1b4fbbdc889f2d8b9293ffad47085a334780d69e
> 100644
> --- a/net/cert/cert_verify_proc_unittest.cc
> +++ b/net/cert/cert_verify_proc_unittest.cc
> @@ -140,8 +140,8 @@ TEST_F(CertVerifyProcTest, WithoutRevocationChecking) {
>  #else
>  #define MAYBE_EVVerification EVVerification
>  #endif
> -TEST_F(CertVerifyProcTest, MAYBE_EVVerification) {
> -  // This certificate will expire Jun 21, 2013.
> +TEST_F(CertVerifyProcTest, DISABLED_EVVerification) {
> +  // DISABLED: This certificate expired Jun 21, 2013.
>    CertificateList certs = CreateCertificateListFromFile(
>        GetTestCertsDirectory(),
>        "comodo.chain.pem",
>
>

Powered by Google App Engine
This is Rietveld 408576698