Omnibox: Add Shortcuts as InstantExtended Provider

Omnibox: Add Shortcuts as InstantExtended Provider

We might as well now that InstantExtended is using the native omnibox.  
Besides, it has a positive effect on quality.

For now, I left the framework that allows InstantExtended to use a
different set of providers.  I'll leave it up to Jered or Brett to decide
if they're ready to get rid of it.

BUG=252892
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208071

[Mark P, 2013-06-21 22:48:09]

If this looks good to you, please go ahead and commit-queue it.

thanks,
mark

[Peter Kasting, 2013-06-21 22:49:27]

LGTM.  CCing Jered so he sees this.

[Jered, 2013-06-21 22:50:57]

https://codereview.chromium.org/17563007/diff/4001/chrome/browser/autocomplet...
File chrome/browser/autocomplete/autocomplete_classifier.cc (right):

https://codereview.chromium.org/17563007/diff/4001/chrome/browser/autocomplet...
chrome/browser/autocomplete/autocomplete_classifier.cc:26: const int
AutocompleteClassifier::kInstantExtendedOmniboxProviders =
Since this is now identical to kDefaultOmniboxProviders, can we just use that?

[commit-bot: I haz the power, 2013-06-21 22:51:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/17563007/4001

[Peter Kasting, 2013-06-21 22:53:10]

https://codereview.chromium.org/17563007/diff/4001/chrome/browser/autocomplet...
File chrome/browser/autocomplete/autocomplete_classifier.cc (right):

https://codereview.chromium.org/17563007/diff/4001/chrome/browser/autocomplet...
chrome/browser/autocomplete/autocomplete_classifier.cc:26: const int
AutocompleteClassifier::kInstantExtendedOmniboxProviders =
On 2013/06/21 22:50:57, Jered wrote:
> Since this is now identical to kDefaultOmniboxProviders, can we just use that?

See Mark's CL description: "For now, I left the framework that allows
InstantExtended to use a different set of providers. I'll leave it up to Jered
or Brett to decide if they're ready to get rid of it."

It makes sense to remove this if you don't think the provider sets will differ
in the future.  If they will, we might as well leave this.

[Jered, 2013-06-21 22:55:34]

On 2013/06/21 22:53:10, Peter Kasting wrote:
>
https://codereview.chromium.org/17563007/diff/4001/chrome/browser/autocomplet...
> File chrome/browser/autocomplete/autocomplete_classifier.cc (right):
> 
>
https://codereview.chromium.org/17563007/diff/4001/chrome/browser/autocomplet...
> chrome/browser/autocomplete/autocomplete_classifier.cc:26: const int
> AutocompleteClassifier::kInstantExtendedOmniboxProviders =
> On 2013/06/21 22:50:57, Jered wrote:
> > Since this is now identical to kDefaultOmniboxProviders, can we just use
that?
> 
> See Mark's CL description: "For now, I left the framework that allows
> InstantExtended to use a different set of providers. I'll leave it up to Jered
> or Brett to decide if they're ready to get rid of it."
> 
> It makes sense to remove this if you don't think the provider sets will differ
> in the future.  If they will, we might as well leave this.

I don't think we want to do anything more with this in the timeframe when
InstantExtended is not the default, so I vote for deleting. I'm fine if that
happens
in a separate CL as this is a nice minimal fix.

[Peter Kasting, 2013-06-21 22:58:40]

On 2013/06/21 22:55:34, Jered wrote:
> I don't think we want to do anything more with this in the timeframe when
> InstantExtended is not the default, so I vote for deleting.

The timeframe I am thinking runs out to about M32, so I'm not sure assuming
Instant Extended is off is the right assumption.

> I'm fine if that
> happens
> in a separate CL as this is a nice minimal fix.

Up to you guys, ultimately.  This might be a good thing to stick on your list of
"stuff to clean up about the current instant implementation".

[commit-bot: I haz the power, 2013-06-22 01:30:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/17563007/4001

[commit-bot: I haz the power, 2013-06-22 02:47:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/17563007/4001

[commit-bot: I haz the power, 2013-06-22 03:10:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/17563007/4001

[commit-bot: I haz the power, 2013-06-22 03:22:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/17563007/4001

[commit-bot: I haz the power, 2013-06-22 03:38:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/17563007/4001

[commit-bot: I haz the power, 2013-06-22 03:45:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/17563007/4001

[commit-bot: I haz the power, 2013-06-22 17:08:40]

Change committed as 208071