Support uninstalling ARC app from Chrome launcher

chrome/browser/ui/app_list/arc/arc_app_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
 
 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
 #include "components/arc/arc_bridge_service.h"
 
 namespace arc {
 
 void GetAndroidAppTargetRect(gfx::Rect& target_rect) {
   // TODO: Figure out where to put the android window.
   target_rect.SetRect(0, 0, 0, 0);
 }
 
 bool LaunchApp(content::BrowserContext* context, const std::string& app_id) {
   ArcAppListPrefs* prefs = ArcAppListPrefs::Get(context);
   CHECK(prefs);
 
   scoped_ptr<ArcAppListPrefs::AppInfo> app_info = prefs->GetApp(app_id);
   if (!app_info) {
-    VLOG(2) << "Cannot launch unavailable app:" << app_id << ".";
+    VLOG(2) << "Cannot launch unavailable app: " << app_id << ".";
     return false;
   }
 
   if (!app_info->ready) {
-    VLOG(2) << "Cannot launch not-ready app:" << app_id << ".";
+    VLOG(2) << "Cannot launch not-ready app: " << app_id << ".";
     return false;
   }
 
   arc::ArcBridgeService* bridge_service = arc::ArcBridgeService::Get();
   if (!bridge_service) {
     VLOG(2) << "Request to launch app when bridge service is not ready: "
             << app_id << ".";
     return false;
   }
   arc::AppInstance* app_instance = bridge_service->app_instance();
@@ skipping 52 matching lines @@
   screen_rect->right = rect.right();
   screen_rect->top = rect.y();
   screen_rect->bottom = rect.bottom();
 
   app_instance->CanHandleResolution(app_info->package_name, app_info->activity,
                                     std::move(screen_rect),
                                     callback);
   return true;
 }
 
+bool UninstallApp(content::BrowserContext* context,
+                  const std::string& package_name) {
+  arc::ArcBridgeService* bridge_service = arc::ArcBridgeService::Get();
+  if (!bridge_service) {
+    VLOG(2) << "Request to uninstall app when bridge service is not ready: "
+            << package_name << ".";
+    return false;
+  }
+  arc::AppInstance* app_instance = bridge_service->app_instance();
+  if (!app_instance) {
+    VLOG(2) << "Request to uninstall app when bridge service is not ready: "
+            << package_name << ".";
+    return false;
+  }
+
+  if (bridge_service->app_version() >= 2) {

[khmel, 2016/03/04 18:35:53]

If you have UninstallApp available you already have version >= 2. Luis could you
please confirm?

[Luis Héctor Chávez, 2016/03/04 21:29:37]

You will always have the method available (compile-time), but may only use it
the other side has version >= 2 (runtime). The explicit check is needed.

nit:

if (bridge_service->app_version() < 2) {
  VLOG(2) << "Request to uninstall app when version " <<
bridge_service->app_version()
          << " does not support it.";
  return false;
}

[victorhsieh0, 2016/03/07 21:00:16]

Done.

+    app_instance->UninstallApp(package_name);
+  } else {
+    LOG(ERROR) << "Require later version to uninstall";
+    return false;
+  }
+
+  return true;
+}
+
 }  // namespace arc