Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1756193007: Fix iOS GN build after r379128. (Closed)

Created:
4 years, 9 months ago by jam
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix iOS GN build after r379128. There's probably a bigger and better fix to ensure this can run on iOS, but given that we're not using mojo on iOS yet, we can punt on that. BUG=586194 NOTRY=true Committed: https://crrev.com/e98cbe0c82391694e653c75812859bb3e8f86ca8 Cr-Commit-Position: refs/heads/master@{#379173}

Patch Set 1 : #

Patch Set 2 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M url/BUILD.gn View 3 chunks +12 lines, -4 lines 0 comments Download
M url/run_all_unittests.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
M url/url.gyp View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
jam
4 years, 9 months ago (2016-03-03 23:47:14 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 9 months ago (2016-03-03 23:48:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756193007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756193007/20001
4 years, 9 months ago (2016-03-03 23:49:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756193007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756193007/40001
4 years, 9 months ago (2016-03-04 00:13:07 UTC) #11
jam
reluctantly putting NOTRY=true because of flakes in slow try bots and the bots are red. ...
4 years, 9 months ago (2016-03-04 01:41:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756193007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756193007/40001
4 years, 9 months ago (2016-03-04 01:42:46 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-04 01:49:34 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 01:51:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e98cbe0c82391694e653c75812859bb3e8f86ca8
Cr-Commit-Position: refs/heads/master@{#379173}

Powered by Google App Engine
This is Rietveld 408576698