Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1756143002: Revert of Add checks to understand crash in NavigationHandle::DidCommitNavigation (Closed)

Created:
4 years, 9 months ago by clamy
Modified:
4 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add checks to understand crash in NavigationHandle::DidCommitNavigation (patchset #3 id:40001 of https://codereview.chromium.org/1735123002/ ) Reason for revert: This has been in Canary for 5 days and was not triggered, so reverting this temporary CHECK. Original issue's description: > Add checks to understand crash in NavigationHandle::DidCommitNavigation > > This CL adds checks to try to understand why a CHECK is being hit in the wild > in NavigationHandle::DidCommitNavigation. > > BUG=589365 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/f20af5b3d9add0310725392646e33d0ed11e1e4f > Cr-Commit-Position: refs/heads/master@{#377881} TBR=nasko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589365 Committed: https://crrev.com/cb0861d834ce620c026ac2759c3728a93ead0eaf Cr-Commit-Position: refs/heads/master@{#378750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
clamy
Created Revert of Add checks to understand crash in NavigationHandle::DidCommitNavigation
4 years, 9 months ago (2016-03-02 14:28:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756143002/1
4 years, 9 months ago (2016-03-02 14:28:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756143002/1
4 years, 9 months ago (2016-03-02 14:31:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756143002/1
4 years, 9 months ago (2016-03-02 15:01:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756143002/1
4 years, 9 months ago (2016-03-02 15:31:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 15:45:32 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 15:46:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb0861d834ce620c026ac2759c3728a93ead0eaf
Cr-Commit-Position: refs/heads/master@{#378750}

Powered by Google App Engine
This is Rietveld 408576698