content/browser/accessibility/dump_accessibility_tree_browsertest.cc - Issue 175613002: Include relationship ARIA objects in serialized accessibility tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 175613002: Include relationship ARIA objects in serialized accessibility tree (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reuse MAYBE(x) for failing android test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/renderer/accessibility/accessibility_node_serializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

index d60abbb7345cb78f565db5b4e7f3f5896dacb4e4..e26dcff4c1a858dddb4b07413c67072ade3bec61 100644

--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

@@ -29,8 +29,8 @@

#include "content/test/content_browser_test_utils.h"

#include "testing/gtest/include/gtest/gtest.h"

-// TODO(dmazzoni): Disabled accessibility tests on Win64. crbug.com/179717

-#if defined(OS_WIN) && defined(ARCH_CPU_X86_64)

+// TODO(aboxhall): Create expectations on Android for these

+#if defined(OS_ANDROID)

#define MAYBE(x) DISABLED_##x

#else

#define MAYBE(x) x

@@ -275,6 +275,11 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,

RunTest(FILE_PATH_LITERAL("aria-combobox.html"));

}

+IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,

+ MAYBE(AccessibilityAriaFlowto)) {

+ RunTest(FILE_PATH_LITERAL("aria-flowto.html"));

IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaInvalid) {

RunTest(FILE_PATH_LITERAL("aria-invalid.html"));

}