Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 175603002: Less strict CHECK for DeviceCapabilities results. (Closed)

Created:
6 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 10 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Less strict CHECK for DeviceCapabilities results. We should crash only if returned result is bigger that buffer we provided. BUG=345605 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M printing/backend/print_backend_win.cc View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 10 months ago (2014-02-21 19:18:01 UTC) #1
Noam Samuel
lgtm
6 years, 10 months ago (2014-02-21 19:20:20 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-21 19:21:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/175603002/1
6 years, 10 months ago (2014-02-21 19:21:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 22:10:19 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268035
6 years, 10 months ago (2014-02-21 22:10:20 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-21 23:19:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/175603002/1
6 years, 10 months ago (2014-02-21 23:22:43 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 23:27:29 UTC) #9
Message was sent while issue was closed.
Change committed as 252685

Powered by Google App Engine
This is Rietveld 408576698