base/base.gyp - Issue 1755973002: Move non-content specific parts of content::MachBroker into base::MachPortBroker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gyp

Issue 1755973002: Move non-content specific parts of content::MachBroker into base::MachPortBroker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Thats what you get for doing a release build without dchecks_always_on. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/base.gyp

diff --git a/base/base.gyp b/base/base.gyp

index 2b93cdac4ab5a7f43667d6493d24bf525c6ec1ac..fff51e9f48aad3b6a96c6d82a038c70b79fce435 100644

--- a/base/base.gyp

+++ b/base/base.gyp

@@ -202,6 +202,7 @@

'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',

'$(SDKROOT)/System/Library/Frameworks/IOKit.framework',

'$(SDKROOT)/System/Library/Frameworks/Security.framework',

+ '$(SDKROOT)/usr/lib/libbsm.dylib',

Mark Mentovai 2016/03/03 23:01:59 Do you have to pull this out of some other .gyp fi

Anand Mistry (off Chromium) 2016/03/04 00:00:50 I've removed this from both content gyp and gn rul

}],

@@ -449,6 +450,7 @@

'mac/foundation_util_unittest.mm',

'mac/libdispatch_task_runner_unittest.cc',

'mac/mac_util_unittest.mm',

+ 'mac/mach_port_broker_unittest.cc',

'mac/objc_property_releaser_unittest.mm',

'mac/scoped_nsobject_unittest.mm',

'mac/scoped_objc_class_swizzler_unittest.mm',

« no previous file with comments | « base/BUILD.gn ('k') | base/base.gypi » ('j') | content/browser/mach_broker_mac.mm » ('J')