Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 175593003: Add test to make sure ChromeVox speaks when we type in the omnibox. (Closed)

Created:
6 years, 10 months ago by dmazzoni
Modified:
6 years, 10 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add test to make sure ChromeVox speaks when we type in the omnibox. BUG=339902 R=plundblad@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dmazzoni
6 years, 10 months ago (2014-02-21 19:31:25 UTC) #1
Peter Lundblad
lgtm Do you want to add this to crbug.com/339902?
6 years, 10 months ago (2014-02-21 23:36:54 UTC) #2
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 10 months ago (2014-02-21 23:42:13 UTC) #3
dmazzoni
On 2014/02/21 23:36:54, Peter Lundblad wrote: > lgtm > > Do you want to add ...
6 years, 10 months ago (2014-02-21 23:42:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/175593003/1
6 years, 10 months ago (2014-02-21 23:42:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 01:09:04 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268286
6 years, 10 months ago (2014-02-22 01:09:04 UTC) #7
dmazzoni
6 years, 10 months ago (2014-02-24 06:21:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r252885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698