Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 1755743003: Revert of Update DNG SDK version. (Closed)

Created:
4 years, 9 months ago by yujieqin
Modified:
4 years, 9 months ago
CC:
reviews_skia.org, adaubert, floriank_google.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update DNG SDK version. (patchset #3 id:40001 of https://codereview.chromium.org/1748363004/ ) Reason for revert: This breaks the ChromeOS build. E.g. https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-CrOS_Link/builds/5215/steps/build%20most/logs/stdio Original issue's description: > Update DNG SDK version. > > * Integrate integer overflow changes from security branch > > BUG=b/26535130 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004 > > Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567 TBR=msarett@google.com,scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/26535130 Committed: https://skia.googlesource.com/skia/+/62c9c4ba61681921f52bf8120a500f6c1724ea50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yujieqin
Created Revert of Update DNG SDK version.
4 years, 9 months ago (2016-03-02 12:07:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755743003/1
4 years, 9 months ago (2016-03-02 12:07:31 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-02 12:07:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755743003/1
4 years, 9 months ago (2016-03-02 12:30:59 UTC) #4
robertphillips
lgtm
4 years, 9 months ago (2016-03-02 12:55:14 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 12:57:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/62c9c4ba61681921f52bf8120a500f6c1724ea50

Powered by Google App Engine
This is Rietveld 408576698