Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Side by Side Diff: src/runtime/runtime-liveedit.cc

Issue 1755673002: AIX: Fix 'may be used uninitialized' compiler errors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/debug/debug-frames.h" 9 #include "src/debug/debug-frames.h"
10 #include "src/debug/liveedit.h" 10 #include "src/debug/liveedit.h"
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 // of JSArray of triplets (pos1, pos1_end, pos2_end) describing list 235 // of JSArray of triplets (pos1, pos1_end, pos2_end) describing list
236 // of diff chunks. 236 // of diff chunks.
237 RUNTIME_FUNCTION(Runtime_LiveEditCompareStrings) { 237 RUNTIME_FUNCTION(Runtime_LiveEditCompareStrings) {
238 HandleScope scope(isolate); 238 HandleScope scope(isolate);
239 CHECK(isolate->debug()->live_edit_enabled()); 239 CHECK(isolate->debug()->live_edit_enabled());
240 DCHECK(args.length() == 2); 240 DCHECK(args.length() == 2);
241 CONVERT_ARG_HANDLE_CHECKED(String, s1, 0); 241 CONVERT_ARG_HANDLE_CHECKED(String, s1, 0);
242 CONVERT_ARG_HANDLE_CHECKED(String, s2, 1); 242 CONVERT_ARG_HANDLE_CHECKED(String, s2, 1);
243 243
244 Handle<JSArray> result = LiveEdit::CompareStrings(s1, s2); 244 Handle<JSArray> result = LiveEdit::CompareStrings(s1, s2);
245 uint32_t array_length; 245 uint32_t array_length = 0;
246 CHECK(result->length()->ToArrayLength(&array_length)); 246 CHECK(result->length()->ToArrayLength(&array_length));
247 if (array_length > 0) { 247 if (array_length > 0) {
248 isolate->debug()->feature_tracker()->Track(DebugFeatureTracker::kLiveEdit); 248 isolate->debug()->feature_tracker()->Track(DebugFeatureTracker::kLiveEdit);
249 } 249 }
250 250
251 return *result; 251 return *result;
252 } 252 }
253 253
254 254
255 // Restarts a call frame and completely drops all frames above. 255 // Restarts a call frame and completely drops all frames above.
(...skipping 22 matching lines...) Expand all
278 // We don't really care what the inlined frame index is, since we are 278 // We don't really care what the inlined frame index is, since we are
279 // throwing away the entire frame anyways. 279 // throwing away the entire frame anyways.
280 const char* error_message = LiveEdit::RestartFrame(it.frame()); 280 const char* error_message = LiveEdit::RestartFrame(it.frame());
281 if (error_message) { 281 if (error_message) {
282 return *(isolate->factory()->InternalizeUtf8String(error_message)); 282 return *(isolate->factory()->InternalizeUtf8String(error_message));
283 } 283 }
284 return heap->true_value(); 284 return heap->true_value();
285 } 285 }
286 } // namespace internal 286 } // namespace internal
287 } // namespace v8 287 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698