Issue 175563003: Remove unused return value from fitsInMaximumImageSize().

Issue 175563003: Remove unused return value from fitsInMaximumImageSize(). (Closed)

Created:
6 years, 10 months ago by Savago-old

Modified:
6 years, 10 months ago

Reviewers:
pdr., Stephen Chennney, fmalita_google_do_not_use

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove unused return value from fitsInMaximumImageSize(). A follow up in the patch review discussion of bug #240184. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167633

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address reviewer's comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
		Source/core/rendering/svg/RenderSVGResourceFilter.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/rendering/svg/RenderSVGResourceFilter.cpp	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pdr.

LGTM with one nit. If you agree, please feel free to upload a new patch ...

6 years, 10 months ago (2014-02-22 01:12:51 UTC) #2

Savago-old

The CQ bit was checked by a.cavalcanti@partner.samsung.com

6 years, 10 months ago (2014-02-22 02:29:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.cavalcanti@partner.samsung.com/175563003/70001

6 years, 10 months ago (2014-02-22 02:29:59 UTC) #4

Message was sent while issue was closed.

Change committed as 167633

Expand Messages | Collapse Messages