Implement GetInstalledFile() in WidevineCdmComponentInstaller.

chrome/browser/component_updater/widevine_cdm_component_installer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/widevine_cdm_component_installer.h"
 
 #include <string.h>
 
 #include <vector>
 
@@ skipping 233 matching lines @@
 
   // Installation is done. Now register the Widevine CDM with chrome.
   current_version_ = version;
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, base::Bind(
       &RegisterWidevineCdmWithChrome, adapter_install_path, version));
   return true;
 }
 
 bool WidevineCdmComponentInstaller::GetInstalledFile(
     const std::string& file, base::FilePath* installed_file) {
-  return false;
+  // Only the CDM is component-updated.
+  if (file != kWidevineCdmFileName)
+    return false;
+
+  if (current_version_.Equals(base::Version(kNullVersion)))
+    return false;  // No CDM has been installed yet.
+
+  base::FilePath installed_cdm_path =
+      GetWidevineCdmBaseDirectory().AppendASCII(current_version_.GetString())
+          .AppendASCII(kWidevineCdmFileName);
+
+  // Ideally we should check if PathExists(installed_cdm_path) here. But this

[Sorin Jianu, 2013/06/21 19:49:24]

This comment can be removed. The function just maps file names to their
location, no need to do any I/O to check the file presence or their integrity. 

You could also avoid the named local variable here and just assigned to the out
parameter of the function. If you prefer the named variable, you could declare
it const. 

Please read waffle's comment about what is expected of this function.

[xhwang, 2013/06/21 19:56:04]

Done.

+  // thread does not allow IO.
+
+  *installed_file = installed_cdm_path;
+  return true;
 }
 
 void FinishWidevineCdmUpdateRegistration(ComponentUpdateService* cus,
                                          const base::Version& version) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   CrxComponent widevine_cdm;
   widevine_cdm.name = "WidevineCdm";
   widevine_cdm.installer = new WidevineCdmComponentInstaller(version);
   widevine_cdm.version = version;
   widevine_cdm.pk_hash.assign(kSha2Hash, &kSha2Hash[sizeof(kSha2Hash)]);
@@ skipping 46 matching lines @@
 #endif  // defined(WIDEVINE_CDM_AVAILABLE) && defined(WIDEVINE_CDM_IS_COMPONENT)
 
 }  // namespace
 
 void RegisterWidevineCdmComponent(ComponentUpdateService* cus) {
 #if defined(WIDEVINE_CDM_AVAILABLE) && defined(WIDEVINE_CDM_IS_COMPONENT)
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
                           base::Bind(&StartWidevineCdmUpdateRegistration, cus));
 #endif  // defined(WIDEVINE_CDM_AVAILABLE) && defined(WIDEVINE_CDM_IS_COMPONENT)
 }