Fix param_name for Properties.

Fix param_name for Properties.

This allows for you to have a property 'event.patchset', which gets put into
a python parameter name "event_patchset", for example. This behavior was
previously broken. Added a working test for it.

BUG=591172
Committed: https://github.com/luci/recipes-py/commit/b044190384a6b5330fbbda7d922f4ead3cc88fb8

[martiniss, 2016-03-01 21:23:23]

martiniss@chromium.org changed reviewers:
+ iannucci@chromium.org

[martiniss, 2016-03-01 21:23:24]

PTAL

[martiniss, 2016-03-01 21:33:32]

Description was changed from

==========
Fix param_name for Properties.

This allows for you to have a property 'event.patchset', which gets put into
a python parameter name "event_patchset", for example. This behavior was
previously broken. Added a working test for it.

BUG=
==========

to

==========
Fix param_name for Properties.

This allows for you to have a property 'event.patchset', which gets put into
a python parameter name "event_patchset", for example. This behavior was
previously broken. Added a working test for it.

BUG=591172
==========

[iannucci, 2016-03-01 22:44:52]

lgtm

[iannucci, 2016-03-01 22:45:43]

On 2016/03/01 at 22:44:52, iannucci wrote:
> lgtm

Though, what do you think about applying a standard transform from property.name
to property_name? Less configuration is better? Can we assert that param_name is
some transformation of prop.name?

[martiniss, 2016-03-02 01:18:22]

On 2016/03/01 at 22:45:43, iannucci wrote:
> On 2016/03/01 at 22:44:52, iannucci wrote:
> > lgtm
> 
> Though, what do you think about applying a standard transform from
property.name to property_name? Less configuration is better? Can we assert that
param_name is some transformation of prop.name?

That would be nice. I would prefer to leave that to a later CL. But good idea,
filed https://crbug.com/591251

[martiniss, 2016-03-02 01:18:24]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-03-02 01:18:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755593003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755593003/1

[commit-bot: I haz the power, 2016-03-02 01:20:48]

Description was changed from

==========
Fix param_name for Properties.

This allows for you to have a property 'event.patchset', which gets put into
a python parameter name "event_patchset", for example. This behavior was
previously broken. Added a working test for it.

BUG=591172
==========

to

==========
Fix param_name for Properties.

This allows for you to have a property 'event.patchset', which gets put into
a python parameter name "event_patchset", for example. This behavior was
previously broken. Added a working test for it.

BUG=591172

Committed:
https://github.com/luci/recipes-py/commit/b044190384a6b5330fbbda7d922f4ead3cc...
==========

[commit-bot: I haz the power, 2016-03-02 01:20:49]

Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/b044190384a6b5330fbbda7d922f4ead3cc...

[martiniss, 2016-03-02 22:02:51]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1756933003/ by martiniss@chromium.org.

The reason for reverting is: Broke findit recipe which uses param_name..