add /img/n/m endpoint to skiaserve

add /img/n/m endpoint to skiaserve

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755563003

Committed: https://skia.googlesource.com/skia/+/46b301d2222b60dd5ab495b917dea163e8be94ef

[joshua.litt, 2016-03-01 20:45:14]

Description was changed from

==========
add /img/n/m endpoint to skiaserve

BUG=skia:
==========

to

==========
add /img/n/m endpoint to skiaserve

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-01 20:48:22]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-03-01 20:48:22]

I'm open to other ways to do this.  I could move all of the logic for drawing
this to Request, but it seems like an SkDebugCanvas feature.  I'm open to other
ways to set this on SkDebugCanvas, or I could move all of this functionality to
a follow up call on SkDebugCanvas which the client can invoke.

[joshualitt, 2016-03-02 15:01:31]

On 2016/03/01 20:48:22, joshualitt wrote:
> I'm open to other ways to do this.  I could move all of the logic for drawing
> this to Request, but it seems like an SkDebugCanvas feature.  I'm open to
other
> ways to set this on SkDebugCanvas, or I could move all of this functionality
to
> a follow up call on SkDebugCanvas which the client can invoke.

After thinking about this CL overnight, I'm less certain we want to muck with
it.  For one, its not very invasive, and for two, atleast in the current design
the GrAuditTrail management is consistent across drawTo(n) and drawTo(n,m).  I'm
worried that if these are broken up, it will be the caller's responsibility to
ensure proper managment of the audit trail.  It just seems like it will be less
clear.  Thoughts?

[ethannicholas, 2016-03-02 16:17:19]

On 2016/03/02 15:01:31, joshualitt wrote:
> On 2016/03/01 20:48:22, joshualitt wrote:
> > I'm open to other ways to do this.  I could move all of the logic for
drawing
> > this to Request, but it seems like an SkDebugCanvas feature.  I'm open to
> other
> > ways to set this on SkDebugCanvas, or I could move all of this functionality
> to
> > a follow up call on SkDebugCanvas which the client can invoke.
> 
> After thinking about this CL overnight, I'm less certain we want to muck with
> it.  For one, its not very invasive, and for two, atleast in the current
design
> the GrAuditTrail management is consistent across drawTo(n) and drawTo(n,m). 
I'm
> worried that if these are broken up, it will be the caller's responsibility to
> ensure proper managment of the audit trail.  It just seems like it will be
less
> clear.  Thoughts?

I share your concerns, but also vote non-invasive vs. overcomplicating things.
lgtm

[joshualitt, 2016-03-02 16:18:13]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-03-02 16:18:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755563003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755563003/40001

[commit-bot: I haz the power, 2016-03-02 16:32:53]

Description was changed from

==========
add /img/n/m endpoint to skiaserve

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
add /img/n/m endpoint to skiaserve

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/46b301d2222b60dd5ab495b917dea163e8be94ef
==========

[commit-bot: I haz the power, 2016-03-02 16:32:54]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/46b301d2222b60dd5ab495b917dea163e8be94ef