test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 1755563002: [interpreter] Properly collect for-in slow mode feedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 1755563002: [interpreter] Properly collect for-in slow mode feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: More recementation Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index 839215f743220550b256ae52c875eb2f62cfaf84..74d75ca0611b0df99f622f6b763d71ff074d51a2 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -205,11 +205,11 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

builder.ForInPrepare(reg)

.ForInDone(reg, reg)

- .ForInNext(reg, reg, reg)

+ .ForInNext(reg, reg, reg, 1)

.ForInStep(reg);

builder.ForInPrepare(wide)

.ForInDone(reg, other)

- .ForInNext(wide, wide, wide)

+ .ForInNext(wide, wide, wide, 1024)

.ForInStep(reg);

// Wide constant pool loads