Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1755553003: Revert of Progress on gamma-correctness in the GPU backend. Fixed conversion of color and profile type to pix… (Closed)

Created:
4 years, 9 months ago by Brian Osman
Modified:
4 years, 9 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Progress on gamma-correctness in the GPU backend. Fixed conversion of color and profile type to pix… (patchset #1 id:1 of https://codereview.chromium.org/1750383002/ ) Reason for revert: GM breakage. Changes to SkGr.cpp appear to be altering behavior on a variety of tests. Debugging... Original issue's description: > Progress on gamma-correctness in the GPU backend. Fixed conversion of color and profile type to pixel config, which makes many things "just work". > > Added (color=8888|f16|srgb) option to gpu configurations, along with gpuf16, gpusrgb, and anglesrgb predefined configs. Runs the gpu backend in gamma-correct mode (with either FP16 linear or sRGB 8888 frambuffers). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1750383002 > > Committed: https://skia.googlesource.com/skia/+/a6f58194733c1c50e4fe5f98585e42344f29b6f0 TBR=mtklein@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/744898aa48e055401e5ef203d5f633e69825bf20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -88 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M dm/DMSrcSink.h View 2 chunks +1 line, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/TestConfigParsing.cpp View 3 chunks +1 line, -16 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 1 chunk +1 line, -6 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 11 chunks +6 lines, -48 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Brian Osman
4 years, 9 months ago (2016-03-01 21:44:05 UTC) #1
Created Revert of Progress on gamma-correctness in the GPU backend. Fixed
conversion of color and profile type to pix…

Powered by Google App Engine
This is Rietveld 408576698