Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: third_party/WebKit/Source/core/editing/Selection.idl

Issue 1755503002: Remove Selection TODO that was fixed by a spec change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Google Inc. All rights reserved. 3 * Copyright (C) 2009 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 12 matching lines...) Expand all
23 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 23 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
24 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 24 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
25 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 */ 28 */
29 29
30 // http://w3c.github.io/selection-api/#idl-def-Selection 30 // http://w3c.github.io/selection-api/#idl-def-Selection
31 31
32 // TODO(yoichio): All long types should be unsigned long. crbug.com/391673 32 // TODO(yoichio): All long types should be unsigned long. crbug.com/391673
33 // TODO(philipj): No arguments are optional in the spec, but some should be:
34 // https://github.com/w3c/selection-api/issues/30
35 [ 33 [
36 ImplementedAs=DOMSelection, 34 ImplementedAs=DOMSelection,
37 WillBeGarbageCollected, 35 WillBeGarbageCollected,
38 ] interface Selection { 36 ] interface Selection {
39 [MeasureAs=SelectionAnchorNode] readonly attribute Node? anchorNode; 37 [MeasureAs=SelectionAnchorNode] readonly attribute Node? anchorNode;
40 [MeasureAs=SelectionAnchorOffset] readonly attribute long anchorOffset; 38 [MeasureAs=SelectionAnchorOffset] readonly attribute long anchorOffset;
41 [MeasureAs=SelectionFocusNode] readonly attribute Node? focusNode; 39 [MeasureAs=SelectionFocusNode] readonly attribute Node? focusNode;
42 [MeasureAs=SelectionFocusOffset] readonly attribute long focusOffset; 40 [MeasureAs=SelectionFocusOffset] readonly attribute long focusOffset;
43 [MeasureAs=SelectionIsCollapsed] readonly attribute boolean isCollapsed; 41 [MeasureAs=SelectionIsCollapsed] readonly attribute boolean isCollapsed;
44 [MeasureAs=SelectionRangeCount] readonly attribute long rangeCount; 42 [MeasureAs=SelectionRangeCount] readonly attribute long rangeCount;
(...skipping 30 matching lines...) Expand all
75 [MeasureAs=SelectionBaseNode] readonly attribute Node? baseNode; 73 [MeasureAs=SelectionBaseNode] readonly attribute Node? baseNode;
76 [MeasureAs=SelectionBaseOffset] readonly attribute long baseOffset; 74 [MeasureAs=SelectionBaseOffset] readonly attribute long baseOffset;
77 [MeasureAs=SelectionExtentNode] readonly attribute Node? extentNode; 75 [MeasureAs=SelectionExtentNode] readonly attribute Node? extentNode;
78 [MeasureAs=SelectionExtentOffset] readonly attribute long extentOffset; 76 [MeasureAs=SelectionExtentOffset] readonly attribute long extentOffset;
79 77
80 // https://github.com/w3c/selection-api/issues/37 78 // https://github.com/w3c/selection-api/issues/37
81 [MeasureAs=SelectionModify] void modify([Default=Undefined] optional DOMStri ng alter, 79 [MeasureAs=SelectionModify] void modify([Default=Undefined] optional DOMStri ng alter,
82 [Default=Undefined] optional DOMStri ng direction, 80 [Default=Undefined] optional DOMStri ng direction,
83 [Default=Undefined] optional DOMStri ng granularity); 81 [Default=Undefined] optional DOMStri ng granularity);
84 }; 82 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698