Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1755443002: MD Settings: fix "Could not find ... settings-shared" console warning (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix "Could not find ... settings-shared" console warning <style include="settings-shared"> requires importing settings_shared_css.html. R=dschuyler@chromium.org BUG=588922 Committed: https://crrev.com/d907e917c5e0f78f73346b3fc5f4fb6446c98d90 Cr-Commit-Position: refs/heads/master@{#378390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Dan Beam
4 years, 9 months ago (2016-03-01 01:58:18 UTC) #2
dschuyler
LGTM and thanks!
4 years, 9 months ago (2016-03-01 02:08:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755443002/1
4 years, 9 months ago (2016-03-01 02:11:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 04:02:06 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 04:03:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d907e917c5e0f78f73346b3fc5f4fb6446c98d90
Cr-Commit-Position: refs/heads/master@{#378390}

Powered by Google App Engine
This is Rietveld 408576698