Record only qualified unresolved name usages.

pkg/analyzer/test/src/summary/index_unit_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:convert';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/summary/format.dart';
 import 'package:analyzer/src/summary/idl.dart';
@@ skipping 612 matching lines @@
 class A {}
 A myVariable = null;
 ''');
     Element element = findElement('A');
     assertThat(element).isReferencedAt('A myVariable');
   }
 
   void test_usedName_isInvokedBy() {
     verifyNoTestUnitErrors = false;
     _indexTestUnit('''
-class A {
-  Function x;
-
-  m() {
-    x(); // 1
-    this.x(); // 2
-    y(); // 3
-    this.y(); // 4
-  }
+class C {
+  x() {}
+}
+main(C c) {
+  x(); // nq
+  c.x(); // q
+  y(); // nq
+  c.y(); // q
 }
 ''');
     assertThatName('x')
-      ..isInvokedAt('x(); // 1', isQualified: false)
-      ..isInvokedAt('x(); // 2');
+      ..isNotInvokedAt('x(); // nq')
+      ..isNotInvokedAt('x(); // q');
     assertThatName('y')
-      ..isInvokedAt('y(); // 3', isQualified: false, isResolved: false)
-      ..isInvokedAt('y(); // 4', isResolved: false);
+      ..isNotInvokedAt('y(); // nq')
+      ..isInvokedAt('y(); // q');
   }
 
   void test_usedName_isReferencedBy() {
     verifyNoTestUnitErrors = false;
     _indexTestUnit('''
-class A {
+class C {
   int x;
-
-  m() {
-    x; // 1
-    this.x; // 2
-    y; // 3
-    this.y; // 4
-  }
+}
+main(C c) {
+  x; // nq
+  c.x; // q
+  y; // nq
+  c.y; // q
 }
 ''');
     assertThatName('x')
-      ..isReferencedAt('x; // 1', isQualified: false)
-      ..isReferencedAt('x; // 2');
+      ..isNotReferencedAt('x; // nq')
+      ..isNotReferencedAt('x; // q');
     assertThatName('y')
-      ..isReferencedAt('y; // 3', isQualified: false, isResolved: false)
-      ..isReferencedAt('y; // 4', isResolved: false);
+      ..isNotReferencedAt('y; // nq')
+      ..isReferencedAt('y; // q');
   }
 
   void _assertDefinedName(String name, IndexNameKind kind, String search) {
     int offset = findOffset(search);
     int nameId = _getStringId(name);
     for (int i = 0; i < unitIndex.definedNames.length; i++) {
       if (unitIndex.definedNames[i] == nameId &&
           unitIndex.definedNameKinds[i] == kind &&
           unitIndex.definedNameOffsets[i] == offset) {
         return;
@@ skipping 25 matching lines @@
     }
     if (matchIndex != null &&
         unitIndex.usedElementKinds[matchIndex] == expectedRelationKind) {
       // TODO(scheglov) verify 'qualified' and 'resolved'
       return;
     }
     _failWithIndexDump(
         'not found\n$element $expectedRelationKind at $expectedLocation');
   }
 
-  void _assertUsedName(
-      String name, IndexRelationKind kind, ExpectedLocation expectedLocation) {
+  void _assertUsedName(String name, IndexRelationKind kind,
+      ExpectedLocation expectedLocation, bool isNot) {
     int nameId = _getStringId(name);
     for (int i = 0; i < unitIndex.usedNames.length; i++) {
       if (unitIndex.usedNames[i] == nameId &&
           unitIndex.usedNameKinds[i] == kind &&
           unitIndex.usedNameOffsets[i] == expectedLocation.offset) {
+        if (isNot) {
+          _failWithIndexDump('Unexpected $name $kind at $expectedLocation');
+        }
         // TODO(scheglov) verify 'qualified' and 'resolved'
         return;
       }
     }
+    if (isNot) {
+      return;
+    }
     _failWithIndexDump('Not found $name $kind at $expectedLocation');
   }
 
   ExpectedLocation _expectedLocation(String search,
       {int length, bool isQualified: false, bool isResolved: true}) {
     int offset = findOffset(search);
     if (length == null) {
       length = getLeadingIdentifierLength(search);
     }
     return new ExpectedLocation(
@@ skipping 116 matching lines @@
         test._expectedLocation(search, length: length));
   }
 }
 
 class _NameIndexAssert {
   final PackageIndexAssemblerTest test;
   final String name;
 
   _NameIndexAssert(this.test, this.name);
 
-  void isInvokedAt(String search,
-      {int length, bool isQualified: true, bool isResolved: true}) {
-    test._assertUsedName(
-        name,
-        IndexRelationKind.IS_INVOKED_BY,
-        test._expectedLocation(search,
-            length: length, isQualified: isQualified, isResolved: isResolved));
+  void isInvokedAt(String search, {int length}) {
+    test._assertUsedName(name, IndexRelationKind.IS_INVOKED_BY,
+        test._expectedLocation(search, length: length), false);
   }
 
-  void isReferencedAt(String search,
-      {int length, bool isQualified: true, bool isResolved: true}) {
-    test._assertUsedName(
-        name,
-        IndexRelationKind.IS_REFERENCED_BY,
-        test._expectedLocation(search,
-            length: length, isQualified: isQualified, isResolved: isResolved));
+  void isNotInvokedAt(String search, {int length}) {
+    test._assertUsedName(name, IndexRelationKind.IS_INVOKED_BY,
+        test._expectedLocation(search, length: length), true);
+  }
+
+  void isNotReferencedAt(String search, {int length}) {
+    test._assertUsedName(name, IndexRelationKind.IS_REFERENCED_BY,
+        test._expectedLocation(search, length: length), true);
+  }
+
+  void isReferencedAt(String search, {int length}) {
+    test._assertUsedName(name, IndexRelationKind.IS_REFERENCED_BY,
+        test._expectedLocation(search, length: length), false);
   }
 }