Issue 175543006: Pass in "--author 'name <email@somewhere.com>" when doing git patches in apply_issue.py

Issue 175543006: Pass in "--author 'name <email@somewhere.com>" when doing git patches in apply_issue.py (Closed)

Created:
6 years, 10 months ago by Ryan Tseng

Modified:
6 years, 10 months ago

Reviewers:
agable, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Pass in "--author 'name <email@somewhere.com>" when doing git patches in apply_issue.py This is to tackle the issue that slaves don't have global git vars set up. BUG=339171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252705

Patch Set 2 : init() -> apply_issue() #

Patch Set 3 : Removed unneeded if #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	apply_issue.py	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
	M	checkout.py	View	1	6 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

agable

https://codereview.chromium.org/175543006/diff/1/checkout.py File checkout.py (right): https://codereview.chromium.org/175543006/diff/1/checkout.py#newcode556 checkout.py:556: commit_user, post_processors=None, base_ref=None, name=None, email=None): These should be parameters ...

6 years, 10 months ago (2014-02-22 00:01:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/175543006/70002

6 years, 10 months ago (2014-02-22 00:24:35 UTC) #6

Message was sent while issue was closed.

Change committed as 252705

Expand Messages | Collapse Messages