chrome/renderer/printing/print_web_view_helper.cc - Issue 175543005: Use the single argument overload of WebFrame::create().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper.cc

Issue 175543005: Use the single argument overload of WebFrame::create(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/printing/print_web_view_helper.cc

diff --git a/chrome/renderer/printing/print_web_view_helper.cc b/chrome/renderer/printing/print_web_view_helper.cc

index c4ee72abf3d3450c4a8fa24a5763fc30693d48fb..63e36dd08645d3cf16ebf42f6839eb9cadbfa0cf 100644

--- a/chrome/renderer/printing/print_web_view_helper.cc

+++ b/chrome/renderer/printing/print_web_view_helper.cc

@@ -465,8 +465,7 @@ void PrintWebViewHelper::PrintHeaderAndFooter(

blink::WebView* web_view = blink::WebView::create(NULL);

web_view->settings()->setJavaScriptEnabled(true);

- // We don't need to use the frame ID for this frame, so we pass 0 for it.

- blink::WebFrame* frame = blink::WebFrame::create(NULL, 0);

+ blink::WebFrame* frame = blink::WebFrame::create(NULL);

web_view->setMainFrame(frame);

base::StringValue html(