Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 175543002: CC: Fix overlow in multiply. (Closed)

Created:
6 years, 10 months ago by epenner
Modified:
6 years, 10 months ago
Reviewers:
danakj, reveman, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

CC: Fix overlow in multiply. The soft limit calculation can overflow given high byte values. BUG=345426 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252731

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Test #

Total comments: 1

Patch Set 4 : Format. #

Patch Set 5 : Mimimal patch for cherry-pick. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
epenner
Ptal. See my comments on the other bug. If this is the only issue I'd ...
6 years, 10 months ago (2014-02-21 18:47:21 UTC) #1
danakj
Can you add a test that will guard this change?
6 years, 10 months ago (2014-02-21 18:49:49 UTC) #2
epenner
On 2014/02/21 18:49:49, danakj wrote: > Can you add a test that will guard this ...
6 years, 10 months ago (2014-02-21 20:55:03 UTC) #3
danakj
Thanks for the test LGTM https://codereview.chromium.org/175543002/diff/70001/cc/trees/layer_tree_host_impl.h File cc/trees/layer_tree_host_impl.h (right): https://codereview.chromium.org/175543002/diff/70001/cc/trees/layer_tree_host_impl.h#newcode350 cc/trees/layer_tree_host_impl.h:350: const GlobalStateThatImpactsTilePriority global_tile_state() { ...
6 years, 10 months ago (2014-02-21 21:00:46 UTC) #4
epenner
On 2014/02/21 21:00:46, danakj wrote: > Thanks for the test LGTM > > https://codereview.chromium.org/175543002/diff/70001/cc/trees/layer_tree_host_impl.h > ...
6 years, 10 months ago (2014-02-21 21:14:31 UTC) #5
epenner
Okay, fixed issues and test is now in another patch here: https://codereview.chromium.org/165773004/ Landing this as ...
6 years, 10 months ago (2014-02-21 21:18:49 UTC) #6
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 10 months ago (2014-02-21 21:19:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/175543002/160001
6 years, 10 months ago (2014-02-21 21:20:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 23:15:18 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268161
6 years, 10 months ago (2014-02-21 23:15:18 UTC) #10
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-21 23:17:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/175543002/160001
6 years, 10 months ago (2014-02-21 23:20:04 UTC) #12
epenner
The CQ bit was unchecked by epenner@chromium.org
6 years, 10 months ago (2014-02-21 23:37:18 UTC) #13
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 10 months ago (2014-02-21 23:37:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/175543002/160001
6 years, 10 months ago (2014-02-22 01:25:41 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 02:27:42 UTC) #16
Message was sent while issue was closed. 
Change committed as 252731

Powered by Google App Engine
This is Rietveld 408576698