Do not change the case of titles in Utils.setResultInTitle().

media/test/data/eme_player_js/utils.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Utils provide logging functions and other JS functions commonly used by the
 // app and media players.
 var Utils = new function() {
   this.titleChanged = false;
 };
 
@@ skipping 163 matching lines @@
   return hex_str;
 };
 
 Utils.hasPrefix = function(msg, prefix) {
   var message = String.fromCharCode.apply(null, Utils.convertToUint8Array(msg));
   return message.substring(0, prefix.length) == prefix;
 };
 
 Utils.installTitleEventHandler = function(element, event) {
   element.addEventListener(event, function(e) {
-    Utils.setResultInTitle(e.type);
+    Utils.setResultInTitle(e.type.toUpperCase());

[ddorwin, 2016/03/04 19:00:16]

There is an "ended" event that would conflict with the "ENDED" constant!

Also, consider "EVENT_RECEIVED-e.type.toUpperCase()".

[sandersd (OOO until July 31), 2016/03/04 19:26:00]

Indeed there is, but tests are explicitly relying on that. And also note that
adding a prefix without changing the constant makes no difference, since
titlewatcher doesn't require the string to be at the start.

In general, this CL assumes that installTitleEventHandler() is intended to end
the test, but any call to failTest() should not cause the test to succeed. Hence
the case difference between those two paths.

[ddorwin, 2016/03/04 20:14:06]

Hmm. Maybe all the expected strings should have spaces or something (e.g. "E N D
E D"). We can write a JS function to do that here.
Ah, I originally thought "ENDED" was tests complete, but we're actually looking
for playback to have ended.

[sandersd (OOO until July 31), 2016/03/04 20:40:17]

Acknowledged.

   }, false);
 };
 
 Utils.isRenewalMessage = function(message) {
   if (message.messageType != 'license-renewal')
     return false;
 
   if (!Utils.hasPrefix(message.message, EME_RENEWAL_MESSAGE_HEADER)) {
     Utils.failTest('license-renewal message doesn\'t contain expected header',
                    EME_RENEWAL_MISSING_HEADER);
@@ skipping 54 matching lines @@
   if (forceInvalidResponse) {
     Utils.timeLog('Not sending request - forcing an invalid response.');
     return onResponseCallbackFn(Utils.convertToUint8Array("Invalid response."));
   }
   sendRequestAttempt();
 };
 
 Utils.setResultInTitle = function(title) {
   // If document title is 'ENDED', then update it with new title to possibly
   // mark a test as failure.  Otherwise, keep the first title change in place.
-  if (!this.titleChanged || document.title.toUpperCase() == 'ENDED')
-    document.title = title.toUpperCase();
+  if (!this.titleChanged || document.title == 'ENDED')
+    document.title = title;
   Utils.timeLog('Set document title to: ' + title + ', updated title: ' +
                 document.title);
   this.titleChanged = true;
 };
 
 Utils.timeLog = function(/**/) {
   if (arguments.length == 0)
     return;
   var time = Utils.getCurrentTimeString();
   // Log to document.
   Utils.documentLog(arguments[0], time);
   // Log to JS console.
   var logString = time + ' - ';
   for (var i = 0; i < arguments.length; i++) {
     logString += ' ' + arguments[i];
   }
   console.log(logString);
 };