runtime/vm/debugger.cc - Issue 17554003: Change static calls in unoptimized code to always call via a stub. Using ICData, the call count of …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 17554003: Change static calls in unoptimized code to always call via a stub. Using ICData, the call count of … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger.cc

===================================================================

--- runtime/vm/debugger.cc (revision 24306)

+++ runtime/vm/debugger.cc (working copy)

@@ -1585,8 +1585,9 @@

} else if (bpt->breakpoint_kind_ == PcDescriptors::kFuncCall) {

func_to_instrument = bpt->function();

const Code& code = Code::Handle(func_to_instrument.CurrentCode());

- const Function& callee =

- Function::Handle(code.GetStaticCallTargetFunctionAt(bpt->pc_));

+ ASSERT(!code.is_optimized());

+ const Function& callee = Function::Handle(

+ CodePatcher::GetUnoptimizedStaticCallTargetAt(bpt->pc_, code));

ASSERT(!callee.IsNull());

if (IsDebuggable(callee)) {

func_to_instrument = callee.raw();

« no previous file with comments | « runtime/vm/code_patcher_x64_test.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »