Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: runtime/vm/code_patcher_ia32_test.cc

Issue 17554003: Change static calls in unoptimized code to always call via a stub. Using ICData, the call count of … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
11 #include "vm/dart_entry.h" 11 #include "vm/dart_entry.h"
12 #include "vm/instructions.h" 12 #include "vm/instructions.h"
13 #include "vm/native_entry.h" 13 #include "vm/native_entry.h"
14 #include "vm/native_entry_test.h" 14 #include "vm/native_entry_test.h"
15 #include "vm/stub_code.h" 15 #include "vm/stub_code.h"
16 #include "vm/symbols.h" 16 #include "vm/symbols.h"
17 #include "vm/unit_test.h" 17 #include "vm/unit_test.h"
18 18
19 namespace dart { 19 namespace dart {
20 20
21 CODEGEN_TEST_GENERATE(NativePatchStaticCall, test) {
22 SequenceNode* node_seq = test->node_sequence();
23 const String& native_name =
24 String::ZoneHandle(Symbols::New("TestStaticCallPatching"));
25 NativeFunction native_function =
26 reinterpret_cast<NativeFunction>(TestStaticCallPatching);
27 test->function().set_is_native(true);
28 node_seq->Add(new ReturnNode(Scanner::kDummyTokenIndex,
29 new NativeBodyNode(Scanner::kDummyTokenIndex,
30 test->function(),
31 native_name,
32 native_function)));
33 }
34
35 CODEGEN_TEST2_GENERATE(PatchStaticCall, function, test) {
36 SequenceNode* node_seq = test->node_sequence();
37 ArgumentListNode* arguments = new ArgumentListNode(Scanner::kDummyTokenIndex);
38 node_seq->Add(new ReturnNode(Scanner::kDummyTokenIndex,
39 new StaticCallNode(Scanner::kDummyTokenIndex,
40 function, arguments)));
41 }
42
43 CODEGEN_TEST2_RUN(PatchStaticCall, NativePatchStaticCall, Instance::null());
44
45 #define __ assembler-> 21 #define __ assembler->
46 22
47 ASSEMBLER_TEST_GENERATE(IcDataAccess, assembler) { 23 ASSEMBLER_TEST_GENERATE(IcDataAccess, assembler) {
48 const String& class_name = String::Handle(Symbols::New("ownerClass")); 24 const String& class_name = String::Handle(Symbols::New("ownerClass"));
49 const Script& script = Script::Handle(); 25 const Script& script = Script::Handle();
50 const Class& owner_class = 26 const Class& owner_class =
51 Class::Handle(Class::New(class_name, script, Scanner::kDummyTokenIndex)); 27 Class::Handle(Class::New(class_name, script, Scanner::kDummyTokenIndex));
52 const String& function_name = String::Handle(Symbols::New("callerFunction")); 28 const String& function_name = String::Handle(Symbols::New("callerFunction"));
53 const Function& function = Function::Handle( 29 const Function& function = Function::Handle(
54 Function::New(function_name, RawFunction::kRegularFunction, 30 Function::New(function_name, RawFunction::kRegularFunction,
(...skipping 22 matching lines...) Expand all
77 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data); 53 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);
78 EXPECT_STREQ("targetFunction", 54 EXPECT_STREQ("targetFunction",
79 String::Handle(ic_data.target_name()).ToCString()); 55 String::Handle(ic_data.target_name()).ToCString());
80 EXPECT_EQ(1, ic_data.num_args_tested()); 56 EXPECT_EQ(1, ic_data.num_args_tested());
81 EXPECT_EQ(0, ic_data.NumberOfChecks()); 57 EXPECT_EQ(0, ic_data.NumberOfChecks());
82 } 58 }
83 59
84 } // namespace dart 60 } // namespace dart
85 61
86 #endif // TARGET_ARCH_IA32 62 #endif // TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698