Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 17554003: Change static calls in unoptimized code to always call via a stub. Using ICData, the call count of … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1349 matching lines...) Expand 10 before | Expand all | Expand 10 after
1360 GenerateDartCall(deopt_id, 1360 GenerateDartCall(deopt_id,
1361 token_pos, 1361 token_pos,
1362 &StubCode::CallStaticFunctionLabel(), 1362 &StubCode::CallStaticFunctionLabel(),
1363 PcDescriptors::kFuncCall, 1363 PcDescriptors::kFuncCall,
1364 locs); 1364 locs);
1365 AddStaticCallTarget(function); 1365 AddStaticCallTarget(function);
1366 __ Drop(argument_count); 1366 __ Drop(argument_count);
1367 } 1367 }
1368 1368
1369 1369
1370 void FlowGraphCompiler::EmitUnoptimizedStaticCall(
1371 const Function& target_function,
1372 const Array& arguments_descriptor,
1373 intptr_t argument_count,
1374 intptr_t deopt_id,
1375 intptr_t token_pos,
1376 LocationSummary* locs) {
1377 const ICData& ic_data = ICData::ZoneHandle(
1378 ICData::New(parsed_function().function(), // Caller function.
1379 String::Handle(target_function.name()),
1380 arguments_descriptor,
1381 deopt_id,
1382 0)); // No arguments checked.
1383 ic_data.AddTarget(target_function);
1384 __ LoadObject(R5, ic_data);
1385 GenerateDartCall(deopt_id,
1386 token_pos,
1387 &StubCode::UnoptimizedStaticCallLabel(),
1388 PcDescriptors::kFuncCall,
1389 locs);
1390 __ Drop(argument_count);
1391 }
1392
1393
1370 void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg, 1394 void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg,
1371 const Object& obj, 1395 const Object& obj,
1372 bool needs_number_check, 1396 bool needs_number_check,
1373 intptr_t token_pos) { 1397 intptr_t token_pos) {
1374 if (needs_number_check && 1398 if (needs_number_check &&
1375 (obj.IsMint() || obj.IsDouble() || obj.IsBigint())) { 1399 (obj.IsMint() || obj.IsDouble() || obj.IsBigint())) {
1376 __ Push(reg); 1400 __ Push(reg);
1377 __ PushObject(obj); 1401 __ PushObject(obj);
1378 __ BranchLink(&StubCode::IdenticalWithNumberCheckLabel()); 1402 __ BranchLink(&StubCode::IdenticalWithNumberCheckLabel());
1379 AddCurrentDescriptor(PcDescriptors::kRuntimeCall, 1403 AddCurrentDescriptor(PcDescriptors::kRuntimeCall,
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
1782 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 1806 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
1783 __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex)); 1807 __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex));
1784 } 1808 }
1785 1809
1786 1810
1787 #undef __ 1811 #undef __
1788 1812
1789 } // namespace dart 1813 } // namespace dart
1790 1814
1791 #endif // defined TARGET_ARCH_ARM 1815 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698