Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 17554003: Change static calls in unoptimized code to always call via a stub. Using ICData, the call count of … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1428 matching lines...) Expand 10 before | Expand all | Expand 10 after
1439 GenerateDartCall(deopt_id, 1439 GenerateDartCall(deopt_id,
1440 token_pos, 1440 token_pos,
1441 &StubCode::CallStaticFunctionLabel(), 1441 &StubCode::CallStaticFunctionLabel(),
1442 PcDescriptors::kFuncCall, 1442 PcDescriptors::kFuncCall,
1443 locs); 1443 locs);
1444 AddStaticCallTarget(function); 1444 AddStaticCallTarget(function);
1445 __ Drop(argument_count); 1445 __ Drop(argument_count);
1446 } 1446 }
1447 1447
1448 1448
1449 void FlowGraphCompiler::EmitUnoptimizedStaticCall(
1450 const Function& target_function,
1451 const Array& arguments_descriptor,
1452 intptr_t argument_count,
1453 intptr_t deopt_id,
1454 intptr_t token_pos,
1455 LocationSummary* locs) {
1456 const ICData& ic_data = ICData::ZoneHandle(
1457 ICData::New(parsed_function().function(), // Caller function.
1458 String::Handle(target_function.name()),
1459 arguments_descriptor,
1460 deopt_id,
1461 0)); // No arguments checked.
1462 ic_data.AddTarget(target_function);
1463 __ LoadObject(ECX, ic_data);
1464 GenerateDartCall(deopt_id,
1465 token_pos,
1466 &StubCode::UnoptimizedStaticCallLabel(),
1467 PcDescriptors::kFuncCall,
1468 locs);
1469 __ Drop(argument_count);
1470 }
1471
1472
1449 void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg, 1473 void FlowGraphCompiler::EmitEqualityRegConstCompare(Register reg,
1450 const Object& obj, 1474 const Object& obj,
1451 bool needs_number_check, 1475 bool needs_number_check,
1452 intptr_t token_pos) { 1476 intptr_t token_pos) {
1453 if (needs_number_check) { 1477 if (needs_number_check) {
1454 if (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()) { 1478 if (!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint()) {
1455 needs_number_check = false; 1479 needs_number_check = false;
1456 } 1480 }
1457 } 1481 }
1458 1482
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
1924 __ movups(reg, Address(ESP, 0)); 1948 __ movups(reg, Address(ESP, 0));
1925 __ addl(ESP, Immediate(kFpuRegisterSize)); 1949 __ addl(ESP, Immediate(kFpuRegisterSize));
1926 } 1950 }
1927 1951
1928 1952
1929 #undef __ 1953 #undef __
1930 1954
1931 } // namespace dart 1955 } // namespace dart
1932 1956
1933 #endif // defined TARGET_ARCH_IA32 1957 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698