Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: url/ipc/url_param_traits.cc

Issue 1755363003: Revert of Mustash: Move GURL ParamTraits to url/ipc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « url/ipc/url_param_traits.h ('k') | url/ipc/url_param_traits_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/ipc/url_param_traits.cc
diff --git a/url/ipc/url_param_traits.cc b/url/ipc/url_param_traits.cc
deleted file mode 100644
index e40ae8f9a3c9ccc4558cf6fb559f0342ebec545d..0000000000000000000000000000000000000000
--- a/url/ipc/url_param_traits.cc
+++ /dev/null
@@ -1,52 +0,0 @@
-// Copyright (c) 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "url/ipc/url_param_traits.h"
-
-#include "url/gurl.h"
-
-namespace IPC {
-
-void ParamTraits<GURL>::Write(base::Pickle* m, const GURL& p) {
- if (p.possibly_invalid_spec().length() > url::kMaxURLChars) {
- m->WriteString(std::string());
- return;
- }
-
- // Beware of print-parse inconsistency which would change an invalid
- // URL into a valid one. Ideally, the message would contain this flag
- // so that the read side could make the check, but performing it here
- // avoids changing the on-the-wire representation of such a fundamental
- // type as GURL. See https://crbug.com/166486 for additional work in
- // this area.
- if (!p.is_valid()) {
- m->WriteString(std::string());
- return;
- }
-
- m->WriteString(p.possibly_invalid_spec());
- // TODO(brettw) bug 684583: Add encoding for query params.
-}
-
-bool ParamTraits<GURL>::Read(const base::Pickle* m,
- base::PickleIterator* iter,
- GURL* p) {
- std::string s;
- if (!iter->ReadString(&s) || s.length() > url::kMaxURLChars) {
- *p = GURL();
- return false;
- }
- *p = GURL(s);
- if (!s.empty() && !p->is_valid()) {
- *p = GURL();
- return false;
- }
- return true;
-}
-
-void ParamTraits<GURL>::Log(const GURL& p, std::string* l) {
- l->append(p.spec());
-}
-
-} // namespace IPC
« no previous file with comments | « url/ipc/url_param_traits.h ('k') | url/ipc/url_param_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698