IndexedDB: Pass origin to platform/IPC, rather than DatabaseIdentifier

IndexedDB: Pass origin to platform/IPC, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin as a GURL.

BUG=591240
R=mkwst@chromium.org

Committed: https://crrev.com/ab08537f91041bb00b4060e0ba6a770e9eab3d64
Cr-Commit-Position: refs/heads/master@{#379994}

[jsbell, 2016-03-02 21:31:26]

mkwst@ - please take a look?

(Same as the other CL but this touches the IPC as well. Same caveats about
url::Origin apply here, of course.)

[Mike West, 2016-03-03 05:49:09]

https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/i...
File content/common/indexed_db/indexed_db_messages.h (right):

https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/i...
content/common/indexed_db/indexed_db_messages.h:51: IPC_STRUCT_MEMBER(GURL,
origin)
I think I'm missing something here... If you're changing these messages anyway,
why not change them to `url::Origin`?

[jsbell, 2016-03-08 17:17:11]

https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/i...
File content/common/indexed_db/indexed_db_messages.h (right):

https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/i...
content/common/indexed_db/indexed_db_messages.h:51: IPC_STRUCT_MEMBER(GURL,
origin)
On 2016/03/03 05:49:08, Mike West wrote:
> I think I'm missing something here... If you're changing these messages
anyway,
> why not change them to `url::Origin`?

On the content/browser side ("back end") this is used/passed around/serialized
as a GURL. If we don't mind converting url::Origin to GURL that's fine.
Otherwise I'd prefer to do this incrementally (switch to GURL first to be
consistent end-to-end, then convert everything to url::Origin)

[Mike West, 2016-03-08 20:15:43]

On 2016/03/08 at 17:17:11, jsbell wrote:
>
https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/i...
> File content/common/indexed_db/indexed_db_messages.h (right):
> 
>
https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/i...
> content/common/indexed_db/indexed_db_messages.h:51: IPC_STRUCT_MEMBER(GURL,
origin)
> On 2016/03/03 05:49:08, Mike West wrote:
> > I think I'm missing something here... If you're changing these messages
anyway,
> > why not change them to `url::Origin`?
> 
> On the content/browser side ("back end") this is used/passed around/serialized
as a GURL. If we don't mind converting url::Origin to GURL that's fine.
Otherwise I'd prefer to do this incrementally (switch to GURL first to be
consistent end-to-end, then convert everything to url::Origin)

Meh. LGTM.

[jsbell, 2016-03-08 22:28:19]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-03-08 22:29:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755343002/1

[commit-bot: I haz the power, 2016-03-09 00:29:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-09 00:31:14]

Description was changed from

==========
IndexedDB: Pass origin to platform/IPC, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin as a GURL.

BUG=591240
R=mkwst@chromium.org
==========

to

==========
IndexedDB: Pass origin to platform/IPC, rather than DatabaseIdentifier

Don't convert an origin to a DatabaseIdentifier just to immediately
convert it back to an origin. Just pass the origin as a GURL.

BUG=591240
R=mkwst@chromium.org

Committed: https://crrev.com/ab08537f91041bb00b4060e0ba6a770e9eab3d64
Cr-Commit-Position: refs/heads/master@{#379994}
==========

[commit-bot: I haz the power, 2016-03-09 00:31:15]

Patchset 1 (id:??) landed as
https://crrev.com/ab08537f91041bb00b4060e0ba6a770e9eab3d64
Cr-Commit-Position: refs/heads/master@{#379994}