Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1755343002: IndexedDB: Pass origin to platform/IPC, rather than DatabaseIdentifier (Closed)

Created:
4 years, 9 months ago by jsbell
Modified:
4 years, 9 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, cmumford, darin-cc_chromium.org, dglazkov+blink, jam, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Pass origin to platform/IPC, rather than DatabaseIdentifier Don't convert an origin to a DatabaseIdentifier just to immediately convert it back to an origin. Just pass the origin as a GURL. BUG=591240 R=mkwst@chromium.org Committed: https://crrev.com/ab08537f91041bb00b4060e0ba6a770e9eab3d64 Cr-Commit-Position: refs/heads/master@{#379994}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -61 lines) Patch
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 3 chunks +6 lines, -18 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/child/indexed_db/webidbfactory_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/child/indexed_db/webidbfactory_impl.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 3 chunks +6 lines, -6 lines 2 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jsbell
mkwst@ - please take a look? (Same as the other CL but this touches the ...
4 years, 9 months ago (2016-03-02 21:31:26 UTC) #1
Mike West
https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/indexed_db_messages.h File content/common/indexed_db/indexed_db_messages.h (right): https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/indexed_db_messages.h#newcode51 content/common/indexed_db/indexed_db_messages.h:51: IPC_STRUCT_MEMBER(GURL, origin) I think I'm missing something here... If ...
4 years, 9 months ago (2016-03-03 05:49:09 UTC) #2
jsbell
https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/indexed_db_messages.h File content/common/indexed_db/indexed_db_messages.h (right): https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/indexed_db_messages.h#newcode51 content/common/indexed_db/indexed_db_messages.h:51: IPC_STRUCT_MEMBER(GURL, origin) On 2016/03/03 05:49:08, Mike West wrote: > ...
4 years, 9 months ago (2016-03-08 17:17:11 UTC) #3
Mike West
On 2016/03/08 at 17:17:11, jsbell wrote: > https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/indexed_db_messages.h > File content/common/indexed_db/indexed_db_messages.h (right): > > https://codereview.chromium.org/1755343002/diff/1/content/common/indexed_db/indexed_db_messages.h#newcode51 ...
4 years, 9 months ago (2016-03-08 20:15:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755343002/1
4 years, 9 months ago (2016-03-08 22:29:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 00:29:38 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 00:31:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab08537f91041bb00b4060e0ba6a770e9eab3d64
Cr-Commit-Position: refs/heads/master@{#379994}

Powered by Google App Engine
This is Rietveld 408576698