[MIPS] Use IRT shim instead of dummy IRT shim

[MIPS] Use IRT shim instead of dummy IRT shim

IRT shim is needed as it whitelists NaCl IRT interfaces exposed under
PNaCl.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275
TEST= Build Chromium for MIPS

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252847

[petarj, 2014-02-21 19:16:54]

Follow up to Mark's comment at:
https://codereview.chromium.org/152133007/#msg20

PTAL.

[jvoung (off chromium), 2014-02-21 19:46:48]

Thanks

https://codereview.chromium.org/175533002/diff/1/ppapi/native_client/src/untr...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
(right):

https://codereview.chromium.org/175533002/diff/1/ppapi/native_client/src/untr...
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:26:
'enable_mips': 1,
This might need some rejiggering in nacl's build/untrusted.gypi as well? There's
currently no recipe for pnacl_native_biased + mips.

The recipe would end up being not-actually-biased, since the IRT itself is not
biased (unless you also change the IRT build rule for MIPS).

[petarj, 2014-02-21 20:25:28]

On 2014/02/21 19:46:48, jvoung (cr) wrote:
> Thanks
> 
>
https://codereview.chromium.org/175533002/diff/1/ppapi/native_client/src/untr...
> File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
> (right):
> 
>
https://codereview.chromium.org/175533002/diff/1/ppapi/native_client/src/untr...
> ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:26:
> 'enable_mips': 1,
> This might need some rejiggering in nacl's build/untrusted.gypi as well?

Yes, but that is a separate change.
Here is what we have in mind:
(temp) http://pastebin.mozilla.org/4358860

[jvoung (off chromium), 2014-02-21 21:02:32]

lgtm

https://codereview.chromium.org/175533002/diff/1/ppapi/native_client/src/untr...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
(right):

https://codereview.chromium.org/175533002/diff/1/ppapi/native_client/src/untr...
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:26:
'enable_mips': 1,
On 2014/02/21 19:46:48, jvoung (cr) wrote:
> This might need some rejiggering in nacl's build/untrusted.gypi as well?
There's
> currently no recipe for pnacl_native_biased + mips.
> 
> The recipe would end up being not-actually-biased, since the IRT itself is not
> biased (unless you also change the IRT build rule for MIPS).


Okay thanks, please leave a comment by the untrusted.gypi recipe (when you send
out that CL) clarifying that the it's not supposed to be biased bitcode since
the IRT itself is not biased. Seems reasonable to have the comment in the
untrusted.gypi file instead of here, since the build_irt: 1 rules are also
there.

If you care about the size of the shims, you can add some ifdefs later to cut
out a bulk of the code. I'm also working on a CL to move some of this into the
IRT though: https://codereview.chromium.org/164373010/

[petarj, 2014-02-21 22:29:09]

The CQ bit was checked by petarj@mips.com

[commit-bot: I haz the power, 2014-02-21 22:32:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petarj@mips.com/175533002/1

[commit-bot: I haz the power, 2014-02-22 00:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-22 00:31:30]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[petarj, 2014-02-22 01:00:19]

The CQ bit was checked by petarj@mips.com

[commit-bot: I haz the power, 2014-02-22 01:00:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petarj@mips.com/175533002/1

[commit-bot: I haz the power, 2014-02-22 01:36:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petarj@mips.com/175533002/1

[commit-bot: I haz the power, 2014-02-22 03:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-22 03:12:34]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[petarj, 2014-02-22 12:05:20]

The CQ bit was checked by petarj@mips.com

[commit-bot: I haz the power, 2014-02-22 12:05:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petarj@mips.com/175533002/1

[commit-bot: I haz the power, 2014-02-23 08:04:38]

Change committed as 252847