Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1755313002: Optimize ElementId search, rename the test file. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -211 lines) Patch
M pkg/analysis_server/lib/src/services/index2/index2.dart View 4 chunks +76 lines, -9 lines 0 comments Download
D pkg/analysis_server/test/services/index2/index2.dart View 1 chunk +0 lines, -158 lines 0 comments Download
A + pkg/analysis_server/test/services/index2/index2_test.dart View 4 chunks +1 line, -42 lines 0 comments Download
M pkg/analysis_server/test/services/index2/test_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-02 20:31:12 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-02 20:44:51 UTC) #2
scheglov
4 years, 9 months ago (2016-03-02 21:02:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
faf59757c8c0db128572e52b13bf2a34d34a96b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698