Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1755293002: update SkSmallAllocator to force internal allocations to be 16-byte aligned (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

update SkSmallAllocator to force internal allocations to be 16-byte aligned BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755293002 Committed: https://skia.googlesource.com/skia/+/e2b0a0a0349b1c2acbd1eb5c1da7eed012f0980d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M include/core/SkTypes.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkSmallAllocator.h View 4 chunks +20 lines, -11 lines 0 comments Download
M tests/SmallAllocatorTest.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
reed1
ptal
4 years, 9 months ago (2016-03-02 20:20:05 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755293002/1
4 years, 9 months ago (2016-03-02 20:20:17 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/859)
4 years, 9 months ago (2016-03-02 20:22:28 UTC) #7
mtklein
lgtm
4 years, 9 months ago (2016-03-02 21:02:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755293002/1
4 years, 9 months ago (2016-03-02 21:02:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e2b0a0a0349b1c2acbd1eb5c1da7eed012f0980d
4 years, 9 months ago (2016-03-02 21:03:49 UTC) #12
herb_g
4 years, 9 months ago (2016-03-02 22:21:53 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698