core/src/fxcrt/fx_basic_gcc_unittest.cpp - Issue 1755273002: Fix parsing of object numbers > 16,777,216.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxcrt/fx_basic_gcc_unittest.cpp

Issue 1755273002: Fix parsing of object numbers > 16,777,216. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 PDFium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "core/include/fxcrt/fx_system.h"

	6 #include "testing/gtest/include/gtest/gtest.h"

	7
	Tom Sepez 2016/03/02 20:56:38 note: might be fun to cover the other FXYS_toi() note: might be fun to cover the other FXYS_toi() functions while you're at it. dsinclair 2016/03/02 21:27:29 Done. Show quoted text On 2016/03/02 20:56:38, Tom Sepez wrote: > note: might be fun to cover the other FXYS_*toi() functions while you're at it. Done.
	8 TEST(fxcrt, FXSYS_atoui) {

	9 EXPECT_EQ(0, FXSYS_atoui("0"));

	10 EXPECT_EQ(2345, FXSYS_atoui("2345"));

	11 EXPECT_EQ(4294967295, FXSYS_atoui("4294967295"));

	12 EXPECT_EQ(4294967295, FXSYS_atoui("-1"));

	13 }

OLD	NEW