Raise Exception instead of failure when some steps fail.

master/skia_master_scripts/commands.py

Index: master/skia_master_scripts/commands.py
diff --git a/master/skia_master_scripts/commands.py b/master/skia_master_scripts/commands.py
index 0673a6ac5d9c674508eafa6f43b0900a642e2092..3e9a1d2c0619c475f12175d23bcb8ac986aaa243 100644
--- a/master/skia_master_scripts/commands.py
+++ b/master/skia_master_scripts/commands.py
@@ -67,7 +67,8 @@ class SkiaCommands(commands.FactoryCommands):
                      halt_on_failure=False, is_upload_step=False,
                      is_rebaseline_step=False, get_props_from_stdout=None,
                      workdir=None, do_step_if=None,
-                     always_run=False, flunk_on_failure=True):
+                     always_run=False, flunk_on_failure=True,
+                     exception_on_failure=False):
     """Run a slave-side Python script as its own build step."""
     if workdir:
       path_to_script = script
@@ -84,13 +85,14 @@ class SkiaCommands(commands.FactoryCommands):
                        workdir=use_workdir,
                        do_step_if=do_step_if,
                        always_run=always_run,
-                       flunk_on_failure=flunk_on_failure)
+                       flunk_on_failure=flunk_on_failure,
+                       exception_on_failure=exception_on_failure)

[rmistry, 2014/02/24 14:35:24]

What is the difference between exception_on_failures and flunk_on_failure?

[borenet, 2014/02/24 14:42:56]

flunk_on_failure means that if this step fails, the build as a whole fails. 
exception_on_failure means that if this step fails, the master throws an
exception, causing the build to go purple instead of red.

 
   def AddRunCommand(self, command, description='Run', timeout=None,
                     halt_on_failure=False, is_upload_step=False,
                     is_rebaseline_step=False, get_props_from_stdout=None,
                     workdir=None, do_step_if=None, always_run=False,
-                    flunk_on_failure=True):
+                    flunk_on_failure=True, exception_on_failure=False):
     """Runs an arbitrary command, perhaps a binary we built."""
     if not timeout:
       timeout = self.default_timeout
@@ -105,6 +107,7 @@ class SkiaCommands(commands.FactoryCommands):
                          doStepIf=do_step_if or skia_build_step.ShouldDoStep,
                          alwaysRun=always_run,
                          flunkOnFailure=flunk_on_failure,
+                         exception_on_failure=exception_on_failure,
                          hideStepIf=lambda s: s.isSkipped())
 
   def AddRunCommandList(self, command_list, description='Run', timeout=None,