Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: master/skia_master_scripts/commands.py

Issue 175523003: Raise Exception instead of failure when some steps fail. (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Include ALL the factory config files Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | master/skia_master_scripts/factory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: master/skia_master_scripts/commands.py
diff --git a/master/skia_master_scripts/commands.py b/master/skia_master_scripts/commands.py
index 0673a6ac5d9c674508eafa6f43b0900a642e2092..3e9a1d2c0619c475f12175d23bcb8ac986aaa243 100644
--- a/master/skia_master_scripts/commands.py
+++ b/master/skia_master_scripts/commands.py
@@ -67,7 +67,8 @@ class SkiaCommands(commands.FactoryCommands):
halt_on_failure=False, is_upload_step=False,
is_rebaseline_step=False, get_props_from_stdout=None,
workdir=None, do_step_if=None,
- always_run=False, flunk_on_failure=True):
+ always_run=False, flunk_on_failure=True,
+ exception_on_failure=False):
"""Run a slave-side Python script as its own build step."""
if workdir:
path_to_script = script
@@ -84,13 +85,14 @@ class SkiaCommands(commands.FactoryCommands):
workdir=use_workdir,
do_step_if=do_step_if,
always_run=always_run,
- flunk_on_failure=flunk_on_failure)
+ flunk_on_failure=flunk_on_failure,
+ exception_on_failure=exception_on_failure)
def AddRunCommand(self, command, description='Run', timeout=None,
halt_on_failure=False, is_upload_step=False,
is_rebaseline_step=False, get_props_from_stdout=None,
workdir=None, do_step_if=None, always_run=False,
- flunk_on_failure=True):
+ flunk_on_failure=True, exception_on_failure=False):
"""Runs an arbitrary command, perhaps a binary we built."""
if not timeout:
timeout = self.default_timeout
@@ -105,6 +107,7 @@ class SkiaCommands(commands.FactoryCommands):
doStepIf=do_step_if or skia_build_step.ShouldDoStep,
alwaysRun=always_run,
flunkOnFailure=flunk_on_failure,
+ exception_on_failure=exception_on_failure,
hideStepIf=lambda s: s.isSkipped())
def AddRunCommandList(self, command_list, description='Run', timeout=None,
« no previous file with comments | « no previous file | master/skia_master_scripts/factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698