tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Release - Issue 175523003: Raise Exception instead of failure when some steps fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Release

Issue 175523003: Raise Exception instead of failure when some steps fail. (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: Include ALL the factory config files Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Debug-Trybot ('k') | tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Release-Trybot » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Release

diff --git a/tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Release b/tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Release

index 71ac328205a28cfc10a9dc8a638c43007241fcad..9d65b5ac23d5b5bfcbace9b1a1a679ab3365e89f 100644

--- a/tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Release

+++ b/tools/tests/factory_configuration/expected/Build-Win8-VS2012-x86-Release

@@ -108,6 +108,7 @@

'description': 'UpdateScripts',

'doStepIf': <Object>,

'env': {},

+ 'exception_on_failure': <Object>,

'flunkOnFailure': <Object>,

'get_props_from_stdout': {

'buildbot_revision': 'Skiabot scripts updated to (\w+)',

@@ -165,6 +166,7 @@

'description': 'Update',

'doStepIf': <Object>,

'env': {},

+ 'exception_on_failure': <Object>,

'flunkOnFailure': <Object>,

'get_props_from_stdout': {

'got_revision': 'Skia updated to (\w+)',

@@ -224,6 +226,7 @@

'description': 'RunGYP',

'doStepIf': <Object>,

'env': {},

+ 'exception_on_failure': <Object>,

'flunkOnFailure': <Object>,

'get_props_from_stdout': None,

'haltOnFailure': <Object>,

@@ -283,6 +286,7 @@

'description': 'BuildMost',

'doStepIf': <Object>,

'env': {},

+ 'exception_on_failure': <Object>,

'flunkOnFailure': <Object>,

'get_props_from_stdout': None,

'haltOnFailure': <Object>,

@@ -338,6 +342,7 @@

'description': 'Clean',

'doStepIf': <Object>,

'env': {},

+ 'exception_on_failure': <Object>,

'flunkOnFailure': <Object>,

'get_props_from_stdout': None,

'haltOnFailure': <Object>,

@@ -397,6 +402,7 @@

'description': 'Retry_BuildMost',

'doStepIf': <Object>,

'env': {},

+ 'exception_on_failure': <Object>,

'flunkOnFailure': <Object>,

'get_props_from_stdout': None,

'haltOnFailure': <Object>,

@@ -452,6 +458,7 @@

'description': 'Clean',

'doStepIf': <Object>,

'env': {},

+ 'exception_on_failure': <Object>,

'flunkOnFailure': <Object>,

'get_props_from_stdout': None,

'haltOnFailure': <Object>,

@@ -511,6 +518,7 @@

'description': 'Retry_NoWarningsAsErrors_BuildMost',

'doStepIf': <Object>,

'env': {},

+ 'exception_on_failure': <Object>,

'flunkOnFailure': <Object>,

'get_props_from_stdout': None,

'haltOnFailure': <Object>,