Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 17552017: [NaCl SDK] Additional fix for r207878: Add dummy unistd.h for Windows. (Closed)

Created:
7 years, 6 months ago by binji
Modified:
7 years, 6 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Additional fix for r207878: Add dummy unistd.h for Windows. BUG=none TBR=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207961

Patch Set 1 #

Patch Set 2 : more osunistd.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M native_client_sdk/src/libraries/nacl_io_test/mount_html5fs_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_http_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io_test/mount_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
binji
7 years, 6 months ago (2013-06-21 23:48:40 UTC) #1
Sam Clegg
lgtm
7 years, 6 months ago (2013-06-21 23:55:10 UTC) #2
binji
7 years, 6 months ago (2013-06-21 23:57:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r207961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698