gm/tests/outputs/checksum-based-filenames/output-expected/command_line - Issue 17552012: GM: add --missingExpectationsPath option, similar to --mismatchPath

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gm/tests/outputs/checksum-based-filenames/output-expected/command_line

Issue 17552012: GM: add --missingExpectationsPath option, similar to --mismatchPath (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: add_new_flag_and_test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« gm/gmmain.cpp ('K') | « gm/gmmain.cpp ('k') | gm/tests/outputs/checksum-based-filenames/output-expected/mismatchPath/bogusfile » ('j') | gm/tests/outputs/compared-against-empty-dir/output-expected/missingExpectationsPath/565/selftest1.png » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 out/Debug/gm --verbose --writeChecksumBasedFilenames --match selftest1 --config 8888 565 -r gm/tests/inputs/json/different-pixels-no-hierarchy.json --writeJsonS ummaryPath gm/tests/outputs/checksum-based-filenames/output-actual/json-summary. txt --writePath gm/tests/outputs/checksum-based-filenames/output-actual/writePat h --mismatchPath gm/tests/outputs/checksum-based-filenames/output-actual/mismatc hPath	1 out/Debug/gm --verbose --writeChecksumBasedFilenames --match selftest1 --config 8888 565 -r gm/tests/inputs/json/different-pixels-no-hierarchy.json --writeJsonS ummaryPath gm/tests/outputs/checksum-based-filenames/output-actual/json-summary. txt --writePath gm/tests/outputs/checksum-based-filenames/output-actual/writePat h --mismatchPath gm/tests/outputs/checksum-based-filenames/output-actual/mismatc hPath --missingExpectationsPath gm/tests/outputs/checksum-based-filenames/output -actual/missingExpectationsPath
	epoger 2013/06/21 17:46:44 in all the command_line files, we see this new fla in all the command_line files, we see this new flag being passed borenet 2013/06/21 18:01:14 These expectations are getting really unwieldy. I These expectations are getting really unwieldy. Is there a good way to simplify? epoger 2013/06/21 18:06:46 I agree, especially all the "bogusfile"s to make s Show quoted text On 2013/06/21 18:01:14, borenet wrote: > These expectations are getting really unwieldy. Is there a good way to > simplify? I agree, especially all the "bogusfile"s to make sure the directories aren't empty. 1. Do you have a particular simplifying suggestion? 2. Do you think it would be reasonable to commit this change as-is and simplify the test later, so we can start saving time on our buildbots? borenet 2013/06/21 18:14:09 1. Maybe modify the test so that it can handle emp Show quoted text On 2013/06/21 18:06:46, epoger wrote: > On 2013/06/21 18:01:14, borenet wrote: > > These expectations are getting really unwieldy. Is there a good way to > > simplify? > > I agree, especially all the "bogusfile"s to make sure the directories aren't > empty. > > 1. Do you have a particular simplifying suggestion? > > 2. Do you think it would be reasonable to commit this change as-is and simplify > the test later, so we can start saving time on our buildbots? 1. Maybe modify the test so that it can handle empty or nonexistent directories? FWIW I think "whitespace.txt" is a better name for an empty placeholder file. It makes it clear that nobody needs to open it and read it. For changes which affect the buildbot factory config test, I typically won't include the expectations files in the review, or I'll only include one, unless there are some significant changes. 2. Yes, that's fine.
OLD	NEW