Issue 17552008: MIPS: Use AST's type field and merge types for unary, binary & compare ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17552008: MIPS: Use AST's type field and merge types for unary, binary & compare ICs. (Closed)

Created:
7 years, 6 months ago by kilvadyb

Modified:
7 years, 6 months ago

Reviewers:
kisg, Paul Lind, palfia, danno, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Use AST's type field and merge types for unary, binary & compare ICs. Port r15264 (d4c3767) Missing fixed_right_arg().has_value cases added also. BUG=

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -4 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+30 lines, -2 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kisg

LGTM with one nit for the comment, because more than one cases were added: Missing ...

7 years, 6 months ago (2013-06-21 17:49:16 UTC) #2

Committed as r15273.

Expand Messages | Collapse Messages