Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 17552003: Update strings to match the final spec: two forgotten files (Closed)

Created:
7 years, 6 months ago by Pam (message me for reviews)
Modified:
7 years, 6 months ago
Reviewers:
Sergiu
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Update strings to match the final spec: two forgotten files These two files were omitted from the main change to update strings (https://codereview.chromium.org/17320005/). As in that change, this also removes references to "limited users" in the code. BUG=248859 TEST=manual

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M chrome/browser/resources/options/manage_profile_overlay.html View 2 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 8 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Pam (message me for reviews)
Oops, forgot these two files. Please review, thanks! - Pam
7 years, 6 months ago (2013-06-21 13:11:03 UTC) #1
Sergiu
lgtm https://codereview.chromium.org/17552003/diff/1/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): https://codereview.chromium.org/17552003/diff/1/chrome/browser/resources/options/manage_profile_overlay.js#newcode549 chrome/browser/resources/options/manage_profile_overlay.js:549: if (!isSignedIn) Think you forgot to delete this ...
7 years, 6 months ago (2013-06-21 13:21:22 UTC) #2
Pam (message me for reviews)
https://codereview.chromium.org/17552003/diff/1/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): https://codereview.chromium.org/17552003/diff/1/chrome/browser/resources/options/manage_profile_overlay.js#newcode549 chrome/browser/resources/options/manage_profile_overlay.js:549: if (!isSignedIn) On 2013/06/21 13:21:22, Sergiu wrote: > Think ...
7 years, 6 months ago (2013-06-21 13:29:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/17552003/4001
7 years, 6 months ago (2013-06-21 13:30:21 UTC) #4
Pam (message me for reviews)
7 years, 6 months ago (2013-06-21 13:50:05 UTC) #5
Added these files into the main CL.

Powered by Google App Engine
This is Rietveld 408576698