Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1755133002: docs: enlarge the title used by the ios-build-instructions page (Closed)

Created:
4 years, 9 months ago by tfarina
Modified:
4 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: enlarge the title used by the ios-build-instructions page This patch makes the title of ios_build_instructions.md match with the other two (mac_build_instructions.md and linux_build_instructions.md). It also reorders/rewords the title so it matches with the Mac one. This patch also changes the headings to use "##" rather than "____" as that is what is recommended by the style guide at https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#atx-style-headings. BUG=None R=sdefresne@chromium.org Committed: https://crrev.com/f0dd080efb520b42b325ece20afc211fa039edcc Cr-Commit-Position: refs/heads/master@{#378755}

Patch Set 1 #

Total comments: 2

Patch Set 2 : headings - https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#atx-style-headings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M docs/ios_build_instructions.md View 1 7 chunks +8 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tfarina
4 years, 9 months ago (2016-03-02 12:52:51 UTC) #1
sdefresne
lgtm https://codereview.chromium.org/1755133002/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1755133002/diff/1/docs/ios_build_instructions.md#newcode9 docs/ios_build_instructions.md:9: ------------- nit: according to the style guide, this ...
4 years, 9 months ago (2016-03-02 14:16:40 UTC) #2
tfarina
https://codereview.chromium.org/1755133002/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1755133002/diff/1/docs/ios_build_instructions.md#newcode9 docs/ios_build_instructions.md:9: ------------- On 2016/03/02 14:16:40, sdefresne wrote: > nit: according ...
4 years, 9 months ago (2016-03-02 15:25:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755133002/20001
4 years, 9 months ago (2016-03-02 15:26:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 16:02:58 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 16:04:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0dd080efb520b42b325ece20afc211fa039edcc
Cr-Commit-Position: refs/heads/master@{#378755}

Powered by Google App Engine
This is Rietveld 408576698