Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: components/test_runner/layout_dump_flags.h

Issue 1755123004: Remove dump_line_box_trees and debug_render_tree from LayoutDumpFlags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding const-ref enabled by the core changes. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_TEST_RUNNER_LAYOUT_DUMP_FLAGS_H_ 5 #ifndef COMPONENTS_TEST_RUNNER_LAYOUT_DUMP_FLAGS_H_
6 #define COMPONENTS_TEST_RUNNER_LAYOUT_DUMP_FLAGS_H_ 6 #define COMPONENTS_TEST_RUNNER_LAYOUT_DUMP_FLAGS_H_
7 7
8 namespace test_runner { 8 namespace test_runner {
9 9
10 struct LayoutDumpFlags { 10 struct LayoutDumpFlags {
11 LayoutDumpFlags(bool dump_as_text, 11 LayoutDumpFlags(bool dump_as_text,
12 bool dump_child_frames_as_text, 12 bool dump_child_frames_as_text,
13 bool dump_as_markup, 13 bool dump_as_markup,
14 bool dump_child_frames_as_markup, 14 bool dump_child_frames_as_markup,
15 bool dump_child_frame_scroll_positions, 15 bool dump_child_frame_scroll_positions,
16 bool is_printing, 16 bool is_printing)
17 bool dump_line_box_trees,
18 bool debug_render_tree)
19 : dump_as_text(dump_as_text), 17 : dump_as_text(dump_as_text),
20 dump_child_frames_as_text(dump_child_frames_as_text), 18 dump_child_frames_as_text(dump_child_frames_as_text),
21 dump_as_markup(dump_as_text), 19 dump_as_markup(dump_as_text),
22 dump_child_frames_as_markup(dump_child_frames_as_markup), 20 dump_child_frames_as_markup(dump_child_frames_as_markup),
23 dump_child_frame_scroll_positions(dump_child_frame_scroll_positions), 21 dump_child_frame_scroll_positions(dump_child_frame_scroll_positions),
24 is_printing(is_printing), 22 is_printing(is_printing) {}
25 dump_line_box_trees(dump_line_box_trees),
26 debug_render_tree(debug_render_tree) {}
27 23
28 // Default constructor needed for IPC. 24 // Default constructor needed for IPC.
29 // 25 //
30 // Default constructor is |= default| to make sure LayoutDumpFlags is a POD 26 // Default constructor is |= default| to make sure LayoutDumpFlags is a POD
31 // (required until we can remove content/shell/browser dependency on it). 27 // (required until we can remove content/shell/browser dependency on it).
32 LayoutDumpFlags() = default; 28 LayoutDumpFlags() = default;
33 29
34 // If true, the test_shell will produce a plain text dump rather than a 30 // If true, the test_shell will produce a plain text dump rather than a
35 // text representation of the renderer. 31 // text representation of the renderer.
36 bool dump_as_text; 32 bool dump_as_text;
(...skipping 20 matching lines...) Expand all
57 if (dump_as_text) 53 if (dump_as_text)
58 return dump_child_frames_as_text; 54 return dump_child_frames_as_text;
59 else if (dump_as_markup) 55 else if (dump_as_markup)
60 return dump_child_frames_as_markup; 56 return dump_child_frames_as_markup;
61 else 57 else
62 return dump_child_frame_scroll_positions; 58 return dump_child_frame_scroll_positions;
63 } 59 }
64 60
65 // If true, layout is to target printed pages. 61 // If true, layout is to target printed pages.
66 bool is_printing; 62 bool is_printing;
67
68 // Extra flags for debugging layout tests.
69 bool dump_line_box_trees;
70 bool debug_render_tree;
71 }; 63 };
72 64
73 } // namespace test_runner 65 } // namespace test_runner
74 66
75 #endif // COMPONENTS_TEST_RUNNER_LAYOUT_DUMP_FLAGS_H_ 67 #endif // COMPONENTS_TEST_RUNNER_LAYOUT_DUMP_FLAGS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698