third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js - Issue 1755123003: Timeline: quit using Progress, introduce TimelineLifecycleDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

Issue 1755123003: Timeline: quit using Progress, introduce TimelineLifecycleDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

index 21905ea09899de53128b7f43962dd247f100d1a5..3f27d0cae4107ee29df179579a78d9529c7966fc 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

@@ -261,8 +261,6 @@ WebInspector.TimelineModel.forAllRecords = function(recordsArray, preOrderCallba

return processRecords(recordsArray, 0);

}

-WebInspector.TimelineModel.TransferChunkLengthBytes = 5000000;

WebInspector.TimelineModel.DevToolsMetadataEvent = {

TracingStartedInBrowser: "TracingStartedInBrowser",

TracingStartedInPage: "TracingStartedInPage",

@@ -660,6 +658,7 @@ WebInspector.TimelineModel.prototype = {

startCollectingTraceEvents: function(fromFile)

{

+ this._loadedFromFile = fromFile;

this._tracingModel.reset();

this.reset();

this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStarted, { fromFile: fromFile });