third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js - Issue 1755123003: Timeline: quit using Progress, introduce TimelineLifecycleDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

Issue 1755123003: Timeline: quit using Progress, introduce TimelineLifecycleDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js ('k') | third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

index 2d9b050e751f6ea9d27a45cbfe8fd215fcdd17bd..e5e8d952f3f9b89f425535bed071553475802529 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

@@ -397,7 +397,7 @@ InspectorTest.loadTimeline = function(timelineData)

}

InspectorTest.override(WebInspector.TimelineLoader, "_createFileReader", createFileReader);

- WebInspector.TimelineLoader.loadFromFile(InspectorTest.timelineModel(), {}, new WebInspector.Progress());

+ timeline._loadFromFile({});

}

};