Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 17551010: GTTF: TestLauncher: asynchronous and out-of-order execution of tests (Closed)

Created:
7 years, 6 months ago by Paweł Hajdan Jr.
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

GTTF: TestLauncher: asynchronous and out-of-order execution of tests This will make it possible to write a TestLauncherDelegate for small unit tests, for which the overhead of launching each one in its own process would be too big. This new interface makes it possible for the TestLauncherDelegate to e.g. batch test runs, launch child process to run the batch, and then call a series of callbacks for the tests in the batch. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207948

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Patch Set 3 : more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -79 lines) Patch
M base/test/test_launcher.h View 1 3 chunks +33 lines, -4 lines 0 comments Download
M base/test/test_launcher.cc View 1 2 6 chunks +71 lines, -70 lines 0 comments Download
M content/public/test/test_launcher.cc View 3 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
7 years, 6 months ago (2013-06-21 19:03:17 UTC) #1
sky
LGTM https://codereview.chromium.org/17551010/diff/1/base/test/test_launcher.cc File base/test/test_launcher.cc (right): https://codereview.chromium.org/17551010/diff/1/base/test/test_launcher.cc#newcode112 base/test/test_launcher.cc:112: void AddTestResult(const TestResult& result); How about descriptions for ...
7 years, 6 months ago (2013-06-21 19:46:08 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/17551010/diff/1/base/test/test_launcher.cc File base/test/test_launcher.cc (right): https://codereview.chromium.org/17551010/diff/1/base/test/test_launcher.cc#newcode112 base/test/test_launcher.cc:112: void AddTestResult(const TestResult& result); On 2013/06/21 19:46:08, sky wrote: ...
7 years, 6 months ago (2013-06-21 20:56:57 UTC) #3
Paweł Hajdan Jr.
7 years, 6 months ago (2013-06-21 22:58:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r207948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698