Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: trunk/src/chrome/common/extensions/update_manifest.cc

Issue 17551004: Revert 207805 "Differential updates for components. We are addin..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/common/extensions/update_manifest.cc
===================================================================
--- trunk/src/chrome/common/extensions/update_manifest.cc (revision 207822)
+++ trunk/src/chrome/common/extensions/update_manifest.cc (working copy)
@@ -19,9 +19,7 @@
static const char* kExpectedGupdateXmlns =
"http://www.google.com/update2/response";
-UpdateManifest::Result::Result()
- : size(0),
- diff_size(0) {}
+UpdateManifest::Result::Result() {}
UpdateManifest::Result::~Result() {}
@@ -156,7 +154,7 @@
result->crx_url = GURL(GetAttribute(updatecheck, "codebase"));
if (!result->crx_url.is_valid()) {
*error_detail = "Invalid codebase url: '";
- *error_detail += result->crx_url.possibly_invalid_spec();
+ *error_detail += GetAttribute(updatecheck, "codebase");
*error_detail += "'.";
return false;
}
@@ -191,23 +189,6 @@
// sha256 hash of the package in hex format.
result->package_hash = GetAttribute(updatecheck, "hash");
- int size = 0;
- if (base::StringToInt(GetAttribute(updatecheck, "size"), &size)) {
- result->size = size;
- }
-
- // package_fingerprint is optional. It identifies the package, preferably
- // with a modified sha256 hash of the package in hex format.
- result->package_fingerprint = GetAttribute(updatecheck, "fp");
-
- // Differential update information is optional.
- result->diff_crx_url = GURL(GetAttribute(updatecheck, "codebasediff"));
- result->diff_package_hash = GetAttribute(updatecheck, "hashdiff");
- int sizediff = 0;
- if (base::StringToInt(GetAttribute(updatecheck, "sizediff"), &sizediff)) {
- result->diff_size = sizediff;
- }
-
return true;
}
« no previous file with comments | « trunk/src/chrome/common/extensions/update_manifest.h ('k') | trunk/src/chrome/common/omaha_query_params/omaha_query_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698