Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: trunk/src/chrome/browser/component_updater/component_updater_service.h

Issue 17551004: Revert 207805 "Differential updates for components. We are addin..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/component_updater/component_updater_service.h
===================================================================
--- trunk/src/chrome/browser/component_updater/component_updater_service.h (revision 207822)
+++ trunk/src/chrome/browser/component_updater/component_updater_service.h (working copy)
@@ -20,8 +20,6 @@
class FilePath;
}
-class ComponentPatcher;
-
// Component specific installers must derive from this class and implement
// OnUpdateError() and Install(). A valid instance of this class must be
// given to ComponentUpdateService::RegisterComponent().
@@ -39,22 +37,15 @@
virtual bool Install(const base::DictionaryValue& manifest,
const base::FilePath& unpack_path) = 0;
- // Set |installed_file| to the full path to the installed |file|. |file| is
- // the filename of the file in this component's CRX. Returns false if this is
- // not possible (the file has been removed or modified, or its current
- // location is unknown). Otherwise, returns true.
- virtual bool GetInstalledFile(const std::string& file,
- base::FilePath* installed_file) = 0;
-
protected:
virtual ~ComponentInstaller() {}
};
// Describes a particular component that can be installed or updated. This
// structure is required to register a component with the component updater.
-// |pk_hash| is the SHA256 hash of the component's public key. If the component
-// is to be installed then version should be "0" or "0.0", else it should be
-// the current version. |fingerprint| and |name| are optional.
+// Only |name| is optional. |pk_hash| is the SHA256 hash of the component's
+// public key. If the component is to be installed then version should be
+// "0" or "0.0", else it should be the current version.
// |source| is by default pointing to BANDAID but if needed it can be made
// to point to the webstore (CWS_PUBLIC) or to the webstore sandbox. It is
// important to note that the BANDAID source if active throught the day
@@ -64,13 +55,12 @@
enum UrlSource {
BANDAID,
CWS_PUBLIC,
- CWS_SANDBOX,
+ CWS_SANDBOX
};
std::vector<uint8> pk_hash;
ComponentInstaller* installer;
Version version;
- std::string fingerprint;
std::string name;
UrlSource source;
CrxComponent();
@@ -138,11 +128,6 @@
// happens. It should be used mostly as a place to add application specific
// logging or telemetry. |extra| is |event| dependent.
virtual void OnEvent(Events event, int extra) = 0;
- // Creates a new ComponentPatcher in a platform-specific way. This is useful
- // for dependency injection.
- virtual ComponentPatcher* CreateComponentPatcher() = 0;
- // True means that this client can handle delta updates.
- virtual bool DeltasEnabled() const = 0;
};
// Start doing update checks and installing new versions of registered

Powered by Google App Engine
This is Rietveld 408576698